-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17683. Add metrics for acquiring dataset read/write lock. #7211
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
@Hexiaoqiao @haiyang1987 @zhangshuyan0 Sir, could you please help me review this PR when you are free? Thanks a lot. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Thanks @hfutatzhanghb work, let's wait to what it will say. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@haiyang1987 Sir, the failed UTs were all passed in my local. It seems not related with this PR. |
Get it, thanks @hfutatzhanghb , can add new datanode metrics to Metrics.md |
9d7cac9
to
fe23ece
Compare
fe23ece
to
0bdb7fa
Compare
Thanks a lot Sir. Have fixed. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
...ct/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMetrics.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
@Hexiaoqiao @KeeProMise Sir, could you please help me review this PR when you are free? Thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1.
LGTM. +1. |
Hi @hfutatzhanghb The latest CI result is not green. Do you mind to check if it is related to this PR. |
@Hexiaoqiao Sir, it is not related with this PR. All failed UTs were passed in my local. Thanks a lot. |
370e905
to
0d97be0
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failed UTs are not related with this PR. Failed info is "Can not create new native thread" or "timeout after 60000ms" |
Description of PR
Refer to HDFS-17683.
Add metrics for acquiring dataset read/write lock, they can better measure dataset read/write lock performance.