HADOOP-18957. Use StandardCharsets.UTF_8 #6231

pjfanning · 2023-10-27T13:46:13Z

Description of PR

HADOOP-18957

also tidies up some cases like new String("xyz") and just uses "xyz".

How was this patch tested?

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2023-10-28T10:07:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 4s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 77 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 52s		Maven dependency ordering for branch
-1 ❌	mvninstall	39m 17s	/branch-mvninstall-root.txt	root in trunk failed.
+1 💚	compile	19m 24s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 35s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	4m 51s		trunk passed
+1 💚	mvnsite	29m 47s		trunk passed
+1 💚	javadoc	26m 40s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	25m 27s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	44m 59s		trunk passed
+1 💚	shadedclient	39m 16s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	17m 51s		the patch passed
+1 💚	compile	17m 39s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	17m 39s		the patch passed
+1 💚	compile	16m 36s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	16m 36s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-0 ⚠️	checkstyle	4m 47s	/results-checkstyle-root.txt	root: The patch generated 27 new + 2833 unchanged - 15 fixed = 2860 total (was 2848)
+1 💚	mvnsite	29m 46s		the patch passed
+1 💚	javadoc	26m 36s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	28m 29s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	52m 52s		the patch passed
+1 💚	shadedclient	38m 50s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 38s		hadoop-maven-plugins in the patch passed.
+1 💚	unit	3m 24s		hadoop-auth in the patch passed.
+1 💚	unit	0m 32s		hadoop-auth-examples in the patch passed.
+1 💚	unit	19m 12s		hadoop-common in the patch passed.
+1 💚	unit	3m 43s		hadoop-kms in the patch passed.
+1 💚	unit	1m 21s		hadoop-registry in the patch passed.
+1 💚	unit	2m 37s		hadoop-hdfs-client in the patch passed.
-1 ❌	unit	240m 16s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	6m 10s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	unit	3m 13s		hadoop-hdfs-nfs in the patch passed.
+1 💚	unit	5m 47s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 47s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	4m 52s		hadoop-yarn-server-applicationhistoryservice in the patch passed.
+1 💚	unit	2m 1s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	unit	1m 32s		hadoop-yarn-server-web-proxy in the patch passed.
+1 💚	unit	118m 47s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	unit	24m 13s		hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	unit	28m 9s		hadoop-yarn-client in the patch passed.
+1 💚	unit	7m 41s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	unit	1m 9s		hadoop-mapreduce-client-shuffle in the patch passed.
+1 💚	unit	8m 46s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	123m 58s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	unit	15m 14s		hadoop-distcp in the patch passed.
+1 💚	unit	4m 45s		hadoop-yarn-server-timeline-pluginstorage in the patch passed.
+1 💚	unit	1m 16s		hadoop-yarn-server-timelineservice-documentstore in the patch passed.
+1 💚	unit	1m 20s		hadoop-yarn-applications-unmanaged-am-launcher in the patch passed.
+1 💚	unit	21m 15s		hadoop-yarn-services-core in the patch passed.
+1 💚	unit	11m 49s		hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚	unit	1m 20s		hadoop-mapreduce-examples in the patch passed.
+1 💚	unit	7m 5s		hadoop-streaming in the patch passed.
+1 💚	unit	1m 41s		hadoop-archives in the patch passed.
+1 💚	unit	1m 1s		hadoop-rumen in the patch passed.
+1 💚	unit	16m 3s		hadoop-gridmix in the patch passed.
+1 💚	unit	1m 29s		hadoop-extras in the patch passed.
+1 💚	unit	3m 25s		hadoop-aws in the patch passed.
+1 💚	unit	0m 57s		hadoop-kafka in the patch passed.
+1 💚	unit	2m 42s		hadoop-azure in the patch passed.
+1 💚	unit	1m 14s		hadoop-resourceestimator in the patch passed.
+1 💚	unit	1m 4s		hadoop-fs2img in the patch passed.
+1 💚	asflicense	1m 32s		The patch does not generate ASF License warnings.
		1219m 53s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestRollingUpgrade
	hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/1/artifact/out/Dockerfile
GITHUB PR	#6231
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux fc74de1176be 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `18ee816`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/1/testReport/
Max. process+thread count	2347 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archives hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-fs2img U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-10-29T07:34:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 6s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 1s		The patch appears to include 90 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	32m 9s		trunk passed
+1 💚	compile	17m 11s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 0s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	4m 53s		trunk passed
+1 💚	mvnsite	38m 57s		trunk passed
+1 💚	javadoc	35m 27s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	33m 48s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	53m 34s		trunk passed
+1 💚	shadedclient	35m 9s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for patch
+1 💚	mvninstall	20m 57s		the patch passed
+1 💚	compile	16m 29s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	16m 29s		the patch passed
+1 💚	compile	15m 23s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	15m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 46s	/results-checkstyle-root.txt	root: The patch generated 11 new + 3012 unchanged - 15 fixed = 3023 total (was 3027)
+1 💚	mvnsite	38m 45s		the patch passed
+1 💚	javadoc	35m 20s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	33m 42s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	61m 46s		the patch passed
+1 💚	shadedclient	33m 55s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 46s		hadoop-maven-plugins in the patch passed.
+1 💚	unit	3m 28s		hadoop-auth in the patch passed.
+1 💚	unit	0m 48s		hadoop-auth-examples in the patch passed.
+1 💚	unit	19m 24s		hadoop-common in the patch passed.
+1 💚	unit	3m 55s		hadoop-kms in the patch passed.
+1 💚	unit	1m 33s		hadoop-registry in the patch passed.
+1 💚	unit	2m 49s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	219m 15s		hadoop-hdfs in the patch passed.
+1 💚	unit	6m 36s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	unit	3m 25s		hadoop-hdfs-nfs in the patch passed.
+1 💚	unit	1m 34s		hadoop-yarn-api in the patch passed.
+1 💚	unit	6m 13s		hadoop-yarn-common in the patch passed.
+1 💚	unit	4m 4s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	4m 52s		hadoop-yarn-server-applicationhistoryservice in the patch passed.
+1 💚	unit	2m 20s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	unit	1m 47s		hadoop-yarn-server-web-proxy in the patch passed.
+1 💚	unit	116m 3s		hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	unit	24m 48s		hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	unit	28m 47s		hadoop-yarn-client in the patch passed.
+1 💚	unit	7m 58s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	unit	1m 24s		hadoop-mapreduce-client-shuffle in the patch passed.
+1 💚	unit	9m 13s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	126m 31s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	unit	16m 59s		hadoop-distcp in the patch passed.
+1 💚	unit	4m 52s		hadoop-yarn-server-timeline-pluginstorage in the patch passed.
+1 💚	unit	1m 26s		hadoop-yarn-server-timelineservice-documentstore in the patch passed.
+1 💚	unit	1m 33s		hadoop-yarn-applications-unmanaged-am-launcher in the patch passed.
+1 💚	unit	21m 37s		hadoop-yarn-services-core in the patch passed.
+1 💚	unit	11m 49s		hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚	unit	1m 28s		hadoop-mapreduce-examples in the patch passed.
+1 💚	unit	7m 25s		hadoop-streaming in the patch passed.
+1 💚	unit	1m 42s		hadoop-archives in the patch passed.
+1 💚	unit	1m 12s		hadoop-rumen in the patch passed.
+1 💚	unit	17m 10s		hadoop-gridmix in the patch passed.
+1 💚	unit	1m 37s		hadoop-extras in the patch passed.
+1 💚	unit	3m 30s		hadoop-aws in the patch passed.
+1 💚	unit	1m 2s		hadoop-kafka in the patch passed.
+1 💚	unit	2m 43s		hadoop-azure in the patch passed.
+1 💚	unit	1m 19s		hadoop-resourceestimator in the patch passed.
+1 💚	unit	1m 11s		hadoop-fs2img in the patch passed.
+1 💚	asflicense	1m 37s		The patch does not generate ASF License warnings.
		1260m 11s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/2/artifact/out/Dockerfile
GITHUB PR	#6231
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux c802cf9961f2 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7524b88`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/2/testReport/
Max. process+thread count	3534 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archives hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-fs2img U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

more more Update NativeAzureFileSystem.java more more more more

hadoop-yetus · 2023-10-31T08:37:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 6s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 1s		The patch appears to include 90 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 7s		Maven dependency ordering for branch
+1 💚	mvninstall	32m 25s		trunk passed
+1 💚	compile	16m 40s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 3s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	4m 55s		trunk passed
+1 💚	mvnsite	39m 0s		trunk passed
+1 💚	javadoc	35m 35s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	33m 40s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	53m 29s		trunk passed
+1 💚	shadedclient	35m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 33s		Maven dependency ordering for patch
+1 💚	mvninstall	20m 59s		the patch passed
+1 💚	compile	16m 33s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	16m 33s		the patch passed
+1 💚	compile	15m 49s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	15m 49s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 51s	/results-checkstyle-root.txt	root: The patch generated 11 new + 3012 unchanged - 15 fixed = 3023 total (was 3027)
+1 💚	mvnsite	38m 54s		the patch passed
+1 💚	javadoc	35m 30s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	33m 57s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	61m 45s		the patch passed
+1 💚	shadedclient	34m 11s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	0m 51s		hadoop-maven-plugins in the patch passed.
+1 💚	unit	3m 34s		hadoop-auth in the patch passed.
+1 💚	unit	0m 48s		hadoop-auth-examples in the patch passed.
+1 💚	unit	19m 22s		hadoop-common in the patch passed.
+1 💚	unit	3m 52s		hadoop-kms in the patch passed.
+1 💚	unit	1m 33s		hadoop-registry in the patch passed.
+1 💚	unit	2m 52s		hadoop-hdfs-client in the patch passed.
+1 💚	unit	217m 3s		hadoop-hdfs in the patch passed.
+1 💚	unit	6m 43s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	unit	3m 27s		hadoop-hdfs-nfs in the patch passed.
+1 💚	unit	1m 33s		hadoop-yarn-api in the patch passed.
+1 💚	unit	6m 15s		hadoop-yarn-common in the patch passed.
+1 💚	unit	4m 2s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	4m 55s		hadoop-yarn-server-applicationhistoryservice in the patch passed.
+1 💚	unit	2m 20s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	unit	1m 48s		hadoop-yarn-server-web-proxy in the patch passed.
-1 ❌	unit	115m 43s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch passed.
+1 💚	unit	24m 50s		hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	unit	28m 48s		hadoop-yarn-client in the patch passed.
+1 💚	unit	8m 3s		hadoop-mapreduce-client-core in the patch passed.
+1 💚	unit	1m 26s		hadoop-mapreduce-client-shuffle in the patch passed.
+1 💚	unit	9m 14s		hadoop-mapreduce-client-app in the patch passed.
+1 💚	unit	128m 26s		hadoop-mapreduce-client-jobclient in the patch passed.
+1 💚	unit	15m 46s		hadoop-distcp in the patch passed.
+1 💚	unit	5m 0s		hadoop-yarn-server-timeline-pluginstorage in the patch passed.
+1 💚	unit	1m 20s		hadoop-yarn-server-timelineservice-documentstore in the patch passed.
+1 💚	unit	1m 26s		hadoop-yarn-applications-unmanaged-am-launcher in the patch passed.
+1 💚	unit	21m 38s		hadoop-yarn-services-core in the patch passed.
+1 💚	unit	12m 7s		hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚	unit	1m 28s		hadoop-mapreduce-examples in the patch passed.
+1 💚	unit	7m 15s		hadoop-streaming in the patch passed.
+1 💚	unit	1m 44s		hadoop-archives in the patch passed.
+1 💚	unit	1m 14s		hadoop-rumen in the patch passed.
+1 💚	unit	17m 2s		hadoop-gridmix in the patch passed.
+1 💚	unit	1m 50s		hadoop-extras in the patch passed.
+1 💚	unit	3m 32s		hadoop-aws in the patch passed.
+1 💚	unit	1m 2s		hadoop-kafka in the patch passed.
+1 💚	unit	2m 43s		hadoop-azure in the patch passed.
+1 💚	unit	1m 21s		hadoop-resourceestimator in the patch passed.
+1 💚	unit	1m 11s		hadoop-fs2img in the patch passed.
+1 💚	asflicense	1m 30s		The patch does not generate ASF License warnings.
		1260m 25s

Reason	Tests
Failed junit tests	hadoop.yarn.server.resourcemanager.TestRMRestart

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/3/artifact/out/Dockerfile
GITHUB PR	#6231
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1059bde86475 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `3493efc`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/3/testReport/
Max. process+thread count	3472 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archives hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-fs2img U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

pjfanning · 2023-11-10T09:56:05Z

@steveloughran @ayushtkn @slfan1989 Would any of you have time to look at this PR?

ayushtkn · 2023-11-11T04:10:28Z

I will be back by end of next week, if nobody volunteers by then, I can take of this :-)

ayushtkn

Quick Pass & mostly looks good, can we have some restrictions to prevent future usage of these?
Something like this or better?
https://github.com/apache/hadoop/blob/trunk/pom.xml#L194

…base.Charsets

pjfanning · 2023-11-14T13:08:22Z

Quick Pass & mostly looks good, can we have some restrictions to prevent future usage of these? Something like this or better? https://github.com/apache/hadoop/blob/trunk/pom.xml#L194

Good idea. I've committed a banned import for the Guava Charsets class.

hadoop-yetus · 2023-11-15T09:29:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	34m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 4s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 1s		The patch appears to include 90 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 30s		Maven dependency ordering for branch
+1 💚	mvninstall	33m 27s		trunk passed
+1 💚	compile	17m 8s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	15m 12s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	4m 33s		trunk passed
+1 💚	mvnsite	17m 57s		trunk passed
+1 💚	javadoc	8m 19s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 32s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	67m 23s		trunk passed
+1 💚	shadedclient	60m 18s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 43s		Maven dependency ordering for patch
+1 💚	mvninstall	47m 17s		the patch passed
+1 💚	compile	15m 40s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 40s		the patch passed
+1 💚	compile	14m 39s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	14m 39s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 24s	/results-checkstyle-root.txt	root: The patch generated 11 new + 3016 unchanged - 15 fixed = 3027 total (was 3031)
+1 💚	mvnsite	13m 23s		the patch passed
+1 💚	javadoc	8m 17s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 32s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	76m 23s		the patch passed
+1 💚	shadedclient	60m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	730m 58s		root in the patch passed.
+1 💚	asflicense	1m 33s		The patch does not generate ASF License warnings.
		1219m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/4/artifact/out/Dockerfile
GITHUB PR	#6231
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 0315c2901c8e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `146b302`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/4/testReport/
Max. process+thread count	4007 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archives hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-fs2img . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn

Looks good almost, minor question,

anybody else plans to review this? let me know if anyone wants me to hold merging this or needs time

...adoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java

pom.xml

ayushtkn

LGTM

hadoop-yetus · 2023-11-18T10:40:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 3s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 90 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 28s		Maven dependency ordering for branch
+1 💚	mvninstall	35m 18s		trunk passed
+1 💚	compile	18m 7s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	16m 30s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	4m 52s		trunk passed
+1 💚	mvnsite	18m 52s		trunk passed
+1 💚	javadoc	8m 44s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 29s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	68m 53s		trunk passed
+1 💚	shadedclient	66m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 43s		Maven dependency ordering for patch
+1 💚	mvninstall	52m 24s		the patch passed
+1 💚	compile	17m 46s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	17m 46s		the patch passed
+1 💚	compile	16m 34s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	16m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 56s	/results-checkstyle-root.txt	root: The patch generated 11 new + 3012 unchanged - 15 fixed = 3023 total (was 3027)
+1 💚	mvnsite	14m 21s		the patch passed
+1 💚	javadoc	8m 46s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 31s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	77m 29s		the patch passed
+1 💚	shadedclient	67m 5s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	779m 14s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 26s		The patch does not generate ASF License warnings.
		1264m 12s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/5/artifact/out/Dockerfile
GITHUB PR	#6231
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 61d7e9963ebe 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `1f89c99`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/5/testReport/
Max. process+thread count	2759 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archives hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-fs2img . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn · 2023-11-18T12:47:48Z

yetus reports some checksyle warnings

pjfanning · 2023-11-18T15:10:15Z

yetus reports some checksyle warnings

@ayushtkn do you have tips and tricks for how to find checkstyle issues caused by a PR?

This PR is pretty big touching 100s of files and there are 1000s of pre-existing checkstyle issues.

I tried concentrating on going through LineLength and UnusedImports issues but there are 100s of them and after spending a while on them I hadn't yet reached one that was caused by me.

To be honest, I'm not really in a good position time wise to read through such a large checkstyle output. I code mainly in Scala and tools like scalafmt will not only spot checkstyle issues, it will fix them too.

ayushtkn · 2023-11-18T15:17:53Z

There is a link with the checkstyle warnings, just click on it

Some 11 lines
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/5/artifact/out/results-checkstyle-root.txt

./hadoop-common-project/hadoop-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java:299:          digestAuthData = authPair.getBytes(StandardCharsets.UTF_8);: 'block' child has incorrect indentation level 10, expected level should be 8. [Indentation]
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/TestSaslDataTransfer.java:204:      DFSTestUtil.readFile(fs, PATH).getBytes(StandardCharsets.UTF_8));: 'DFSTestUtil' has incorrect indentation level 6, expected level should be 8. [Indentation]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/TaskLog.java:117:      StandardCharsets.UTF_8));: 'StandardCharsets' has incorrect indentation level 6, expected level should be 8. [Indentation]
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestConcatenatedCompressedInput.java:299:        new String(uncompressedBuf, 0, numBytesUncompressed, StandardCharsets.UTF_8);: 'new' has incorrect indentation level 8, expected level should be 10. [Indentation]
./hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DistributedPentomino.java:144:                      (fs.create(input), 64*1024), StandardCharsets.UTF_8));: 'operator new lparen' has incorrect indentation level 22, expected level should be 6. [Indentation]
./hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/dancing/DistributedPentomino.java:144:                      (fs.create(input), 64*1024), StandardCharsets.UTF_8));:23: '(' should be on the previous line. [MethodParamPad]
./hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/CompressionEmulationUtil.java:103:  private static final Charset charsetUTF8 = StandardCharsets.UTF_8;:32: Name 'charsetUTF8' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
./hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/DistributedCacheEmulator.java:117:  private static final Charset charsetUTF8 = StandardCharsets.UTF_8;:32: Name 'charsetUTF8' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
./hadoop-tools/hadoop-gridmix/src/main/java/org/apache/hadoop/mapred/gridmix/GenerateDistCacheData.java:100:  private static final Charset charsetUTF8 = StandardCharsets.UTF_8;:32: Name 'charsetUTF8' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. [ConstantName]
./hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/StreamBaseRecordReader.java:107:      String recordStr = new String(record, start, Math.min(len, statusMaxRecordChars_), StandardCharsets.UTF_8);: Line is longer than 100 characters (found 113). [LineLength]
./hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/TestUnconsumedInput.java:61:        out.write(input.getBytes(StandardCharsets.UTF_8));: 'for' child has incorrect indentation level 8, expected level should be 6. [Indentation]

pjfanning · 2023-11-18T15:53:57Z

The list of 11 checkstyle issues are largely pre-existing issues With the indentation issues, the highlighted lines match the surrounding lines in terms of style. With the charsetUTF8 variables, those var names were pre-existing and I think it is better not to change the names.

In 218321b, I have tried to fix one line length issue and tried to fix a pre-existing indentation issue in a test.

hadoop-yetus · 2023-11-19T11:38:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 4s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 90 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 2s		Maven dependency ordering for branch
+1 💚	mvninstall	31m 0s		trunk passed
+1 💚	compile	16m 4s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	compile	14m 50s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	checkstyle	4m 35s		trunk passed
+1 💚	mvnsite	18m 36s		trunk passed
+1 💚	javadoc	8m 26s		trunk passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 35s		trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	67m 35s		trunk passed
+1 💚	shadedclient	60m 14s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 44s		Maven dependency ordering for patch
+1 💚	mvninstall	47m 21s		the patch passed
+1 💚	compile	15m 45s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 45s		the patch passed
+1 💚	compile	14m 48s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	javac	14m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	4m 25s	/results-checkstyle-root.txt	root: The patch generated 9 new + 3004 unchanged - 26 fixed = 3013 total (was 3030)
+1 💚	mvnsite	13m 24s		the patch passed
+1 💚	javadoc	8m 18s		the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	7m 31s		the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
+1 💚	spotbugs	76m 32s		the patch passed
+1 💚	shadedclient	60m 31s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	738m 57s	/patch-unit-root.txt	root in the patch passed.
+1 💚	asflicense	1m 20s		The patch does not generate ASF License warnings.
		1191m 37s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/6/artifact/out/Dockerfile
GITHUB PR	#6231
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 3d952d5678a7 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `218321b`
Default Java	Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/6/testReport/
Max. process+thread count	4317 (vs. ulimit of 5500)
modules	C: hadoop-maven-plugins hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-auth-examples hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-common-project/hadoop-registry hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-nfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient hadoop-tools/hadoop-distcp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-documentstore hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask hadoop-mapreduce-project/hadoop-mapreduce-examples hadoop-tools/hadoop-streaming hadoop-tools/hadoop-archives hadoop-tools/hadoop-rumen hadoop-tools/hadoop-gridmix hadoop-tools/hadoop-extras hadoop-tools/hadoop-aws hadoop-tools/hadoop-kafka hadoop-tools/hadoop-azure hadoop-tools/hadoop-resourceestimator hadoop-tools/hadoop-fs2img . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6231/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn · 2023-11-20T18:15:15Z

Failed test passes locally

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.9 s - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 33, Failures: 0, Errors: 0, Skipped: 0

…y PJ Fanning. Signed-off-by: Ayush Saxena <[email protected]>

github-actions bot added YARN MapReduce HDFS DistCp trunk Common TOOLS AWS ABFS Maven-Plugins labels Oct 27, 2023

pjfanning added 3 commits October 30, 2023 11:35

HADOOP-18957. Use StandardCharsets.UTF_8

bc04cac

more more Update NativeAzureFileSystem.java more more more more

simpler strings

89f4956

format issues

3493efc

pjfanning force-pushed the HADOOP-18957-utf-8 branch from 7524b88 to 3493efc Compare October 30, 2023 11:35

ayushtkn reviewed Nov 14, 2023

View reviewed changes

add banned import for org.apache.hadoop.thirdparty.com.google.common.…

146b302

…base.Charsets

github-actions bot added the build label Nov 14, 2023

ayushtkn reviewed Nov 17, 2023

View reviewed changes

...adoop-common/src/main/java/org/apache/hadoop/security/token/delegation/web/ServletUtils.java Outdated Show resolved Hide resolved

pom.xml Show resolved Hide resolved

ayushtkn approved these changes Nov 17, 2023

View reviewed changes

remove some lesser used UTF-8 constants

1f89c99

try to fix some checkstyle issues

218321b

ayushtkn merged commit f609460 into apache:trunk Nov 20, 2023
1 of 2 checks passed

pjfanning deleted the HADOOP-18957-utf-8 branch November 25, 2023 09:11

jiajunmao pushed a commit to jiajunmao/hadoop-MLEC that referenced this pull request Feb 6, 2024

HADOOP-18957. Use StandardCharsets.UTF_8 (apache#6231). Contributed b…

ce004d2

…y PJ Fanning. Signed-off-by: Ayush Saxena <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HADOOP-18957. Use StandardCharsets.UTF_8 #6231

HADOOP-18957. Use StandardCharsets.UTF_8 #6231

pjfanning commented Oct 27, 2023 •

edited by ayushtkn

Loading

hadoop-yetus commented Oct 28, 2023

hadoop-yetus commented Oct 29, 2023

hadoop-yetus commented Oct 31, 2023

pjfanning commented Nov 10, 2023

ayushtkn commented Nov 11, 2023

ayushtkn left a comment

pjfanning commented Nov 14, 2023

hadoop-yetus commented Nov 15, 2023

ayushtkn left a comment

ayushtkn left a comment

hadoop-yetus commented Nov 18, 2023

ayushtkn commented Nov 18, 2023

pjfanning commented Nov 18, 2023

ayushtkn commented Nov 18, 2023

pjfanning commented Nov 18, 2023

hadoop-yetus commented Nov 19, 2023

ayushtkn commented Nov 20, 2023

HADOOP-18957. Use StandardCharsets.UTF_8 #6231

HADOOP-18957. Use StandardCharsets.UTF_8 #6231

Conversation

pjfanning commented Oct 27, 2023 • edited by ayushtkn Loading

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented Oct 28, 2023

hadoop-yetus commented Oct 29, 2023

hadoop-yetus commented Oct 31, 2023

pjfanning commented Nov 10, 2023

ayushtkn commented Nov 11, 2023

ayushtkn left a comment

Choose a reason for hiding this comment

pjfanning commented Nov 14, 2023

hadoop-yetus commented Nov 15, 2023

ayushtkn left a comment

Choose a reason for hiding this comment

ayushtkn left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Nov 18, 2023

ayushtkn commented Nov 18, 2023

pjfanning commented Nov 18, 2023

ayushtkn commented Nov 18, 2023

pjfanning commented Nov 18, 2023

hadoop-yetus commented Nov 19, 2023

ayushtkn commented Nov 20, 2023

pjfanning commented Oct 27, 2023 •

edited by ayushtkn

Loading