-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17024. Potential data race introduced by HDFS-15865 #6223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
aajisaka
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @StoneDot
@jojochuang Could you take a look? |
jojochuang
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
asfgit
pushed a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit 93a3c6e)
Thank you @jojochuang! |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
hgromer
pushed a commit
to HubSpot/hadoop
that referenced
this pull request
Jun 6, 2024
hgromer
pushed a commit
to HubSpot/hadoop
that referenced
this pull request
Jun 6, 2024
bbeaudreault
pushed a commit
to HubSpot/hadoop
that referenced
this pull request
Jun 7, 2024
…15865 (apache#6223) (#53) Co-authored-by: Hiroaki Segawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR fixes HDFS-17024.
How was this patch tested?
I cannot test against this issue due to the nature of the data race. This is the reason why I did not include the new test. Also, I ran
mvn clean install -Pdist -Dtar -Ptest-patch
. However, it seems that some tests fail even without this patch in my environment.Additional notes
There is another WiP patch to fix HDFS-17024. However, it seems to be abandoned.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?