YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues. #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rPolicyConfiguration Of Queues.
|
🎊 +1 overall
This message was automatically generated. |
goiri
reviewed
Sep 27, 2023
| int totalPage = | ||
| (totalSize % pageSize == 0) ? totalSize / pageSize : (totalSize / pageSize) + 1; | ||
|
|
||
| // Step3. Returns the Queue Policies result. | ||
| return QueryFederationQueuePoliciesResponse.newInstance( | ||
| totalSize, totalPage, currentPage, pageSize, subFederationQueueWeights); | ||
| totalSize, totalPage, currentPage, pageSize, subFederationQueueWeights); |
There was a problem hiding this comment.
Thanks for your suggestion! I will fix it.
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Sep 27, 2023
| policiesConfigurations.entrySet()) { | ||
| String queue = entry.getKey(); | ||
| SubClusterPolicyConfiguration policyConf = entry.getValue(); | ||
| if(policyConf == null) { |
There was a problem hiding this comment.
Spacing.
In any case, I think we should do:
if (policyConf != null) {
FederationQueueWeight federationQueueWeight = parseFederationQueueWeight(queue, policyConf);
if (federationQueueWeight != null) {
federationQueueWeights.add(federationQueueWeight);
}
}
There was a problem hiding this comment.
Thanks for your suggestion! I will improve this part of the code.
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Thank you very much for your help in reviewing the code! I will continue to improve the function of router command. I will merge this PR into the trunk branch. |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
…rPolicyConfiguration Of Queues. (apache#6121) Contributed by Shilun Fan. Reviewed-by: Inigo Goiri <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11537. [Addendum][Federation] Router CLI Supports List SubClusterPolicyConfiguration Of Queues.
In YARN-11537, we introduced the functionality to list policies, but we require user input for filtering conditions. In this PR, we are extending this feature to allow users to retrieve records even when they do not provide filtering criteria.
How was this patch tested?
Add Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?