YARN-11734. Fix spotbugs in ServiceScheduler#load (#7088) Contributed…

… by Hualong Zhang. Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
apache · Oct 2, 2024 · b781882 · b781882
1 parent 3f637ef
commit b781882
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml b/hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
@@ -726,12 +726,4 @@
     <Package name="org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.placement.schema" />
   </Match>
 
-  <!-- The ServiceScheduler#createConfigFileCache method uses the `load` method,
-       which is not allowed to return null; we can ignore it here. -->
-  <Match>
-    <Class name="org.apache.hadoop.yarn.service.ServiceScheduler"/>
-    <Method name="$1.load(ConfigFile)" />
-    <Bug pattern="NP_NONNULL_RETURN_VIOLATION"/>
-  </Match>
-
 </FindBugsFilter>
diff --git a/...adoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/dev-support/findbugs-exclude.xml b/...adoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/dev-support/findbugs-exclude.xml
@@ -56,4 +56,9 @@
       </Or>
       <Bug pattern="SE_BAD_FIELD" />
   </Match>
+  <Match>
+      <Class name="org.apache.hadoop.yarn.service.ServiceScheduler$1"/>
+      <Method name="load"/>
+      <Bug code="NP" pattern="NP_NONNULL_RETURN_VIOLATION"/>
+  </Match>
 </FindBugsFilter>