addendum

apache · Oct 31, 2023 · 4a6f726 · 4a6f726
1 parent 633cbd4
commit 4a6f726
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/...ct/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockManagerParams.java b/...ct/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockManagerParams.java
@@ -28,7 +28,7 @@
  * This class is used to provide params to {@link BlockManager}.
  */
 @InterfaceAudience.Private
-public class BlockManagerParams {
+public final class BlockManagerParams {
 
   /**
    * Asynchronous tasks are performed in this pool.
@@ -63,6 +63,7 @@ public class BlockManagerParams {
    */
   private final DurationTrackerFactory trackerFactory;
 
+  @SuppressWarnings("checkstyle:parameternumber")
   private BlockManagerParams(ExecutorServiceFuturePool futurePool, BlockData blockData,
       int bufferPoolSize, PrefetchingStatistics prefetchingStatistics, Configuration conf,
       LocalDirAllocator localDirAllocator, int maxBlocksCount,
@@ -119,44 +120,44 @@ public static class BlockManagerParamsBuilder {
     private int maxBlocksCount;
     private DurationTrackerFactory trackerFactory;
 
-    public BlockManagerParamsBuilder setFuturePool(ExecutorServiceFuturePool futurePool) {
-      this.futurePool = futurePool;
+    public BlockManagerParamsBuilder setFuturePool(ExecutorServiceFuturePool pool) {
+      this.futurePool = pool;
       return this;
     }
 
-    public BlockManagerParamsBuilder setBlockData(BlockData blockData) {
-      this.blockData = blockData;
+    public BlockManagerParamsBuilder setBlockData(BlockData data) {
+      this.blockData = data;
       return this;
     }
 
-    public BlockManagerParamsBuilder setBufferPoolSize(int bufferPoolSize) {
-      this.bufferPoolSize = bufferPoolSize;
+    public BlockManagerParamsBuilder setBufferPoolSize(int poolSize) {
+      this.bufferPoolSize = poolSize;
       return this;
     }
 
     public BlockManagerParamsBuilder setPrefetchingStatistics(
-        PrefetchingStatistics prefetchingStatistics) {
-      this.prefetchingStatistics = prefetchingStatistics;
+        PrefetchingStatistics statistics) {
+      this.prefetchingStatistics = statistics;
       return this;
     }
 
-    public BlockManagerParamsBuilder setConf(Configuration conf) {
-      this.conf = conf;
+    public BlockManagerParamsBuilder setConf(Configuration configuration) {
+      this.conf = configuration;
       return this;
     }
 
-    public BlockManagerParamsBuilder setLocalDirAllocator(LocalDirAllocator localDirAllocator) {
-      this.localDirAllocator = localDirAllocator;
+    public BlockManagerParamsBuilder setLocalDirAllocator(LocalDirAllocator dirAllocator) {
+      this.localDirAllocator = dirAllocator;
       return this;
     }
 
-    public BlockManagerParamsBuilder setMaxBlocksCount(int maxBlocksCount) {
-      this.maxBlocksCount = maxBlocksCount;
+    public BlockManagerParamsBuilder setMaxBlocksCount(int blocksCount) {
+      this.maxBlocksCount = blocksCount;
       return this;
     }
 
-    public BlockManagerParamsBuilder setTrackerFactory(DurationTrackerFactory trackerFactory) {
-      this.trackerFactory = trackerFactory;
+    public BlockManagerParamsBuilder setTrackerFactory(DurationTrackerFactory factory) {
+      this.trackerFactory = factory;
       return this;
     }
 

diff --git a/...op-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/prefetch/S3APrefetchFakes.java b/...op-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/prefetch/S3APrefetchFakes.java
@@ -42,7 +42,6 @@
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.LocalDirAllocator;
 import org.apache.hadoop.fs.impl.prefetch.BlockCache;
-import org.apache.hadoop.fs.impl.prefetch.BlockData;
 import org.apache.hadoop.fs.impl.prefetch.BlockManager;
 import org.apache.hadoop.fs.impl.prefetch.BlockManagerParams;
 import org.apache.hadoop.fs.impl.prefetch.ExecutorServiceFuturePool;