HADOOP-19290. Operating on / in ChecksumFileSystem throws NPE. (#7074)…

…. Contributed by Ayush Saxena.
apache · Sep 28, 2024 · 3fda243 · 3fda243
1 parent 01401d7
commit 3fda243
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java b/...p-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
@@ -770,7 +770,7 @@ public FSDataOutputStream createNonRecursive(final Path f,
   abstract class FsOperation {
     boolean run(Path p) throws IOException {
       boolean status = apply(p);
-      if (status) {
+      if (status && !p.isRoot()) {
         Path checkFile = getChecksumFile(p);
         if (fs.exists(checkFile)) {
           apply(checkFile);

diff --git a/...mmon-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java b/...mmon-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestChecksumFileSystem.java
@@ -300,4 +300,11 @@ public void testSetPermissionCrc() throws Exception {
       assertEquals(perm, rawFs.getFileStatus(crc).getPermission());
     }
   }
+
+  @Test
+  public void testOperationOnRoot() throws Exception {
+    Path p = new Path("/");
+    localFs.mkdirs(p);
+    localFs.setReplication(p, localFs.getFileStatus(p).getPermission().toShort());
+  }
 }