Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1956: Update to latest compatible dependency versions. #991

Merged

Conversation

jmuehlner
Copy link
Contributor

No description provided.

Copy link
Contributor Author

@jmuehlner jmuehlner Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages that are not upgraded:

  • Webpack along with all associated plugins and loaders
    angular-templatecache-webpack-plugin has not been updated in 3 years and requires webpack 4, and we are already on the latest version of all webpack-4 compatible packages.
  • @simonwep/pickr
    Version 1.9.1 is available, but fails to compile/parse:
    [INFO] ERROR in ./node_modules/@simonwep/pickr/dist/pickr.min.js 2:9541
    [INFO] Module parse failed: Unexpected token (2:9541)
    [INFO] You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
    [INFO] | /*! Pickr 1.9.1 MIT | https://github.com/Simonwep/pickr */
    [INFO] > !function(t,e){"object"==typeof exports&&"object"==typeof module?module.exports=e():"function"==typeof define
    ... etc etc
    

@necouchman
Copy link
Contributor

@jmuehlner : I think this should go to the patch branch, correct?

@jmuehlner
Copy link
Contributor Author

@jmuehlner : I think this should go to the patch branch, correct?

Yep. I just haven't retargeted it yet.

@jmuehlner jmuehlner changed the base branch from main to patch June 4, 2024 00:13
@jmuehlner jmuehlner marked this pull request as ready for review June 4, 2024 00:13
@jmuehlner jmuehlner changed the title GUACAMOLE-1956: Update to latest version of NPM dependencies. GUACAMOLE-1956: Update to latest compatible dependency versions. Jun 4, 2024
@jmuehlner jmuehlner marked this pull request as draft June 4, 2024 00:20
@jmuehlner jmuehlner force-pushed the GUACAMOLE-1956-update-client-dependencies branch 2 times, most recently from 484328a to 89085b9 Compare June 4, 2024 00:42
@jmuehlner jmuehlner marked this pull request as ready for review June 4, 2024 00:51
doc/licenses/bouncycastle-fips-1.0.2.4/README Outdated Show resolved Hide resolved
doc/licenses/mybatis-guice-4.0.0/README Outdated Show resolved Hide resolved
@jmuehlner jmuehlner force-pushed the GUACAMOLE-1956-update-client-dependencies branch from 89085b9 to de7769c Compare June 11, 2024 17:24
@jmuehlner jmuehlner force-pushed the GUACAMOLE-1956-update-client-dependencies branch from de7769c to 429d968 Compare June 11, 2024 17:27
@mike-jumper mike-jumper merged commit 62820f1 into apache:patch Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants