-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUACAMOLE-1956: Update to latest compatible dependency versions. #991
Merged
mike-jumper
merged 2 commits into
apache:patch
from
jmuehlner:GUACAMOLE-1956-update-client-dependencies
Jun 11, 2024
Merged
GUACAMOLE-1956: Update to latest compatible dependency versions. #991
mike-jumper
merged 2 commits into
apache:patch
from
jmuehlner:GUACAMOLE-1956-update-client-dependencies
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
commented
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Packages that are not upgraded:
- Webpack along with all associated plugins and loaders
angular-templatecache-webpack-plugin
has not been updated in 3 years and requires webpack 4, and we are already on the latest version of all webpack-4 compatible packages. @simonwep/pickr
Version 1.9.1 is available, but fails to compile/parse:[INFO] ERROR in ./node_modules/@simonwep/pickr/dist/pickr.min.js 2:9541 [INFO] Module parse failed: Unexpected token (2:9541) [INFO] You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders [INFO] | /*! Pickr 1.9.1 MIT | https://github.com/Simonwep/pickr */ [INFO] > !function(t,e){"object"==typeof exports&&"object"==typeof module?module.exports=e():"function"==typeof define ... etc etc
@jmuehlner : I think this should go to the |
Yep. I just haven't retargeted it yet. |
jmuehlner
changed the title
GUACAMOLE-1956: Update to latest version of NPM dependencies.
GUACAMOLE-1956: Update to latest compatible dependency versions.
Jun 4, 2024
jmuehlner
force-pushed
the
GUACAMOLE-1956-update-client-dependencies
branch
2 times, most recently
from
June 4, 2024 00:42
484328a
to
89085b9
Compare
mike-jumper
requested changes
Jun 11, 2024
jmuehlner
force-pushed
the
GUACAMOLE-1956-update-client-dependencies
branch
from
June 11, 2024 17:24
89085b9
to
de7769c
Compare
jmuehlner
force-pushed
the
GUACAMOLE-1956-update-client-dependencies
branch
from
June 11, 2024 17:27
de7769c
to
429d968
Compare
mike-jumper
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.