[#6363] improvment(bundle-gcp): Shade some GCP IAM classes in gcp-bundles to avoid possible conflict
#6364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In your enviroment, there are some existing GCP IAM classes conflict with the GCP IAM classes in gcp-bundle? |
FANNG1
reviewed
Jan 26, 2025
bundles/gcp-bundle/build.gradle.kts
Outdated
| @@ -42,6 +42,12 @@ tasks.withType(ShadowJar::class.java) { | |||
| relocate("com.google.common", "org.apache.gravitino.gcp.shaded.com.google.common") | |||
| relocate("com.fasterxml", "org.apache.gravitino.gcp.shaded.com.fasterxml") | |||
| relocate("org.eclipse.jetty", "org.apache.gravitino.gcp.shaded.org.eclipse.jetty") | |||
There was a problem hiding this comment.
why not shade the package in gcp module too?
There was a problem hiding this comment.
Gravitino server will use gcp-bundle for Hadoop catalog only. The conflict only exists in Gravitino server now, so do you mean you need to also consider module gcp for future use case?
FANNG1
reviewed
Jan 26, 2025
bundles/gcp-bundle/build.gradle.kts
Outdated
| @@ -42,6 +42,12 @@ tasks.withType(ShadowJar::class.java) { | |||
| relocate("com.google.common", "org.apache.gravitino.gcp.shaded.com.google.common") | |||
| relocate("com.fasterxml", "org.apache.gravitino.gcp.shaded.com.fasterxml") | |||
| relocate("org.eclipse.jetty", "org.apache.gravitino.gcp.shaded.org.eclipse.jetty") | |||
| relocate("com.google.protobuf", "org.apache.gravitino.gcp.shaded.com.google.protobuf") | |||
| relocate("io.grpc", "org.apache.gravitino.gcp.shaded.io.grpc") | |||
There was a problem hiding this comment.
please keep in alphabetical order
Yes, the module |
FANNG1
approved these changes
Jan 26, 2025
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shade some GCP, gcp and probobuf classes to avoid conflicts with GCP IAM classes.
Why are the changes needed?
To avoid possible class conflicts.
Fix: #6363
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
existing UTs and ITs.