[#6330] chore: add MIT license to missing files

[zzzk1]

What changes were proposed in this pull request?

Add ASF header to missing files

Why are the changes needed?

Fix: #6330

Does this PR introduce any user-facing change?

no

How was this patch tested?

no

[justinmclean]

Do we know where these files come from? ii.e. are they actually Apache licensed?

[jerryshao]

They are just configuration files for Kerberos, which will be used for kerberized integrated test.

[jerryshao]

@jerqi @yuqi1129 can you please help to review?

[yuqi1129]

Those files are template configuration files copied from Linux software kerberos-server which is under the MIT license, so in this case, I'm afraid that we can add an Apache license header here.

@justinmclean , About which license should we use, do you have more input?

[zzzk1]

Maybe we should keep MIT license top and append Apache license.

[justinmclean]

@yuqi1129 No, we cannot add an ASF license; if the code has another license, that license must be kept and not replaced unless you have permission from the original owners. If they are licensed under the MIT lisense then that also needs to be mentioned in the LICENSE file. Can you please give me a link to the original files, so I can check the license.

[yuqi1129]

I'm afraid that we can add an Apache license header here.

Sorry, the word should be we can't NOT we can.

[yuqi1129]

@yuqi1129 No, we cannot add an ASF license; if the code has another license, that license must be kept and not replaced unless you have permission from the original owners. If they are licensed under the MIT lisense then that also needs to be mentioned in the LICENSE file. Can you please give me a link to the original files, so I can check the license.

The krb5-kdc can be found here.

[zzzk1]

I only see kdc.conf

[zzzk1]

I think we should add MIT license for kdc.conf, only one now.

[justinmclean]

See also https://infra.apache.org/licensing-howto.html#permissive-deps for what needs to be done to LICENSE (i.e. MIT license needs to be added).

[yuqi1129]

See also infra.apache.org/licensing-howto.html#permissive-deps for what needs to be done to LICENSE (i.e. MIT license needs to be added).

Can you provide an example of what we should do here? It's too vague here to just give a link. What I (we) want is the specific license content for those three files here.

[jerryshao]

Please be aware that these files are just Kerberos configuration files to make CI work, not the code copying from Kerberos source code.

[justinmclean]

So where were the files copied from? At least one of them looks to come from https://salsa.debian.org/debian/krb5/-/blob/master/src/config-files/kdc.conf

[jerryshao]

It is hard to say it is copied from other projects, because they all look the same.

[justinmclean]

So the issue is:

1. These files were copied from somewhere but we're not 100% sure where from.
2. We can't put ASF headers on them as they are 3rd party code.
3. Because of 1 and 2 they need to be listed in LICENSE
4. They are most likely MIT licensed, but we're not 100% sure.

[justinmclean]

@yuqi1129 seemed sure the files were copied from here, is that incorrect?

[yuqi1129]

@yuqi1129 seemed sure the files were copied from here, is that incorrect?

Yes, the files have been copied from the KDC software used in the Kerberized Hive Docker image. please see:

gravitino/dev/docker/kerberos-hive/start.sh

Lines 35 to 61 in ab85969

	service krb5-kdc start
	service krb5-admin-server start
	# create Kerberos principal and keytab files
	FQDN="HADOOPKRB"
	ADMIN="admin"
	PASS="Admin12!"
	KRB5_KTNAME=/etc/admin.keytab
	echo -e "${PASS}\n${PASS}" | kadmin.local -q "addprinc ${ADMIN}/admin"
	echo -e "${PASS}\n${PASS}" | kadmin.local -q "addprinc cli@${FQDN}"
	echo -e "${PASS}\n${PASS}" | kadmin.local -q "addprinc hdfs/${HOSTNAME}@${FQDN}"
	echo -e "${PASS}\n${PASS}" | kadmin.local -q "addprinc HTTP/${HOSTNAME}@${FQDN}"
	echo -e "${PASS}\n${PASS}" | kadmin.local -q "addprinc hive/${HOSTNAME}@${FQDN}"
	echo -e "${PASS}\n${PASS}" | kadmin.local -q "addprinc yarn/${HOSTNAME}@${FQDN}"
	kadmin.local -q "ktadd -norandkey -k ${KRB5_KTNAME} cli@${FQDN}"
	kadmin.local -q "ktadd -norandkey -k ${KRB5_KTNAME} hdfs/${HOSTNAME}@${FQDN}"
	kadmin.local -q "ktadd -norandkey -k ${KRB5_KTNAME} HTTP/${HOSTNAME}@${FQDN}"
	kadmin.local -q "ktadd -norandkey -k ${KRB5_KTNAME} yarn/${HOSTNAME}@${FQDN}"
	kadmin.local -q "xst -k /hdfs.keytab -norandkey hdfs/${HOSTNAME}@${FQDN}"
	kadmin.local -q "xst -k /hdfs.keytab -norandkey HTTP/${HOSTNAME}@${FQDN}"
	kadmin.local -q "xst -k /yarn.keytab -norandkey yarn/${HOSTNAME}@${FQDN}"
	kadmin.local -q "ktadd -norandkey -k ${KRB5_KTNAME} hive/${HOSTNAME}@${FQDN}"
	kadmin.local -q "xst -k /hive.keytab -norandkey hive/${HOSTNAME}@${FQDN}"
	kadmin.local -q "xst -k /cli.keytab -norandkey cli@${FQDN}"