Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1995]Kill the writer thread when timeout happens to release the lock #3871

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -172,17 +172,23 @@ public DataWriter<D> load(final GenericRecord key)
new CloseOnFlushWriterWrapper<D>(new Supplier<DataWriter<D>>() {
@Override
public DataWriter<D> get() {
Future<DataWriter<D>> future = null;
try {
log.info(String.format("Adding one more writer to loading cache of existing writer "
+ "with size = %d", partitionWriters.size()));
Future<DataWriter<D>> future = createWriterPool.submit(() -> createPartitionWriter(key));
future = createWriterPool.submit(() -> createPartitionWriter(key));
state.setProp(CURRENT_PARTITIONED_WRITERS_COUNTER, partitionWriters.size() + 1);
return future.get(writeTimeoutInterval, TimeUnit.SECONDS);
} catch (ExecutionException | InterruptedException e) {
throw new RuntimeException("Error creating writer", e);
} catch (TimeoutException e) {
throw new RuntimeException(String.format("Failed to create writer due to timeout. The operation timed out after %s seconds.", writeTimeoutInterval), e);
}
finally {
if (future != null && !future.isDone()) {
future.cancel(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have the intended effect? In the issues you were seeing, did we see threads that are sleeping / waiting on IO, which need to be interrupted via cancel?

I am asking this because if the thread needs to actively check if it's being requested to cancel (unless it's actively waiting / sleeping).

Read the below to see what I am describing
https://stackoverflow.com/questions/28043225/future-cancel-does-not-work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@homatthew thanks for the information. The thread here is blocking on getting the HDFS mount table which is an IO operation. I also did a test to do a for loop to talk with HDFS and do timeout, and make sure cancel can work correctly in this case.

}
}
}
}, state), state, key);
}
Expand Down
Loading