[DRAFT DO NOT REVIEW] Wip limit max threads to server #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works for puts, gets and transactions and them also within functions. This solution allows to limit the number of threads handling client requests in a server waiting for a response from a given server. For example, if we configure the system to allow at max 1/2 of the available threads to handle client requests busy towards a given server, supposing we have a 4 servers system with MAX_THREADS=8, if at a given point in time server1 has 4 threads busy waiting to get a response from server2 and another request comes to server1 that would require to communicate with server2, the request will be rejected. This feature could be used in situations when a server is not responding or is responding slowly in order to limit the number of server threads (in the rest of servers) to handle client requests that are busy waiting for an answer from the problematic server. This way, even if a server is not responding or is being very slow, there will always be some threads available to handle client requests in the healthy servers. As a result, a non-responding server would not eventually provoke a 100% traffic loss. In order to implement this feature, a new observer type has been created (SendReceiveMessageObserver). Calls to this observer have been added before a put, get or transaction needs to go to another server (before any change has been made locally) and after the response has been received. With a particular implementation of this observer (see GenericDunitTest.MySendReceiveMessageObserver) that keeps track of the number of threads waiting for an answer to each servers, operations may be rejected if the limit has been surpassed. In GenericDUnitTest that observer is set in the servers and the functionality can be tested manually by looking at the logs. Some refactorings and renamings
albertogpz
force-pushed
the
wip/handle_max_threads_to_server
branch
2 times, most recently
from
ec4bbb7
to
5087bb8
Compare
…d add function to sanctioned data serializables
albertogpz
force-pushed
the
wip/handle_max_threads_to_server
branch
from
5087bb8
to
a1ee7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop)?Is your initial contribution a single, squashed commit?
Does
gradlew buildrun cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?