Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FELIX-6687 Fix handling of typed properties in felix fileinstall #332

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Aug 7, 2024

Due to bug in older version of felix-utils fileinstall can't handle all variants of typed properties properly, especially (a, b, c) syntax..

Due to bug in older version of felix-utils fileinstall can't handle all variants of typed properties properly, especially (a, b, c) syntax..

Signed-off-by: Łukasz Dywicki <[email protected]>
@splatch
Copy link
Contributor Author

splatch commented Sep 26, 2024

Gentle reminder that this PR is open since 6 weeks and no single comment nor action from project team. Other PRs opened later than this got reviewed and merged in meanwhile.

Copy link
Contributor

@stbischof stbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Did you create an issue in felix jira?
And also one for the release process?

If there is no veto in next days i can merge.

But i have no knowledge about release process

@splatch
Copy link
Contributor Author

splatch commented Sep 27, 2024

Yes, I have registered FELIX-6687 in jira.

Looking forward for next steps.

@stbischof stbischof merged commit 736d48c into apache:master Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants