Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated Jackson API ObjectMapper.writerWithType() #17606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jan 6, 2025

Changes

  • Replace usages of ObjectMapper.writeWithType() with the recommended ObjectMapper.writerFor()
  • There is no difference between the two implementations but the older method is deprecated
    since jackson version 2.5 and may be removed in the future

@kfaraz kfaraz changed the title Do not use deprecated API ObjectMapper.writerWithType() Do not use deprecated Jackson API ObjectMapper.writerWithType() Jan 6, 2025
@@ -412,7 +412,7 @@ protected void reduce(

try {
HadoopDruidIndexerConfig.JSON_MAPPER
.writerWithType(Long.class)
.writerFor(Long.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets put this in the forbidden api's ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants