-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRILL-7803] Docker based developer build environment #2115
[DRILL-7803] Docker based developer build environment #2115
Conversation
@nielsbasjes |
NOTE: Doing a full test run to ensure it is correct now. |
Having trouble getting the JDBC test to pass that uses the EmbeddedMySQL.
|
At this point the entire build passes with one exception: TestJdbcPluginWithMySQLIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nielsbasjes
I'm trying this out on my Mac. I'll report back if I get the same error.
Thanks for the contribution!
I didn't see the latest comment about the MySQLIT error.
Should be fixed now. Doing |
Added MAVEN_OPTS settings from the Release documentation |
It worked on my machine
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
DRILL-7803: Docker based developer build environment
Description
I was asked to review a change in Drill ( #2112 ).
When I tried to build the software it turns out that a lot of the build fails over the fact that I have Java 11 installed on my machine by default.
To "fix" this I copied/changed the Docker based build environment I initially created for Hadoop (many years ago) and recently updated for Apache Beam ( apache/beam#13308 | BEAM-10891 )
Because I think it makes sense to have this helper more easily available I put it in this pull request.
This is just an additional tool to make setting up the build environment for Drill a lot easier.
Documentation
Only a small addition for developers who want to build the sourcecode locally.
Testing
On a "empty" (only git and docker are needed) Linux machine with Docker installed (i.e. RedHat/CentOS probably won't work) in the root of the Drill source tree run the
start-build-env.sh
script.After a while (depends on machine and network speed) a bash command prompt should appear with all needed tools to build Apache Drill installed.
Testing is then simply running something like
mvn clean verify
to show everything works.