Addressed review comments

apache · Nov 11, 2024 · 1d3a872 · 1d3a872
1 parent 42e0768
commit 1d3a872
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/contrib/storage-splunk/pom.xml b/contrib/storage-splunk/pom.xml
@@ -61,7 +61,7 @@
     <dependency>
       <groupId>com.github.ben-manes.caffeine</groupId>
       <artifactId>caffeine</artifactId>
-      <version>2.9.3</version>
+      <version>${caffeine.version}</version>
     </dependency>
 
     <!-- Test dependencies -->

diff --git a/contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkSchema.java b/contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkSchema.java
@@ -58,7 +58,7 @@ public SplunkSchema(SplunkStoragePlugin plugin, String queryUserName) {
     this.useCache = plugin.getConfig().getCacheExpiration() >= 0;
 
     if (useCache) {
-      logger.debug("Using splunk schema cache for {}", plugin.getName());
+      logger.info("Using splunk schema cache for {}", plugin.getName());
       this.cache = Caffeine.newBuilder()
           .expireAfterAccess(plugin.getConfig().getCacheExpiration(), TimeUnit.MINUTES)
           .maximumSize(plugin.getConfig().getMaxCacheSize())
@@ -101,8 +101,9 @@ private DynamicDrillTable registerTable(String name, DynamicDrillTable table) {
   }
 
   @Override
-  public CreateTableEntry createNewTable(String tableName, List<String> partitionColumns,
-    StorageStrategy strategy) {
+  public CreateTableEntry createNewTable(String tableName,
+      List<String> partitionColumns,
+      StorageStrategy strategy) {
     if (plugin.getConfig().isWritable() == null || (! plugin.getConfig().isWritable())) {
       throw UserException
         .dataWriteError()

diff --git a/metastore/iceberg-metastore/pom.xml b/metastore/iceberg-metastore/pom.xml
@@ -30,10 +30,6 @@
   <artifactId>drill-iceberg-metastore</artifactId>
   <name>Drill : Metastore : Iceberg</name>
 
-  <properties>
-    <caffeine.version>2.7.0</caffeine.version>
-  </properties>
-
   <dependencies>
     <dependency>
       <groupId>org.apache.drill</groupId>

diff --git a/pom.xml b/pom.xml
@@ -55,6 +55,7 @@
     <avatica.version>1.23.0</avatica.version>
     <avro.version>1.11.4</avro.version>
     <bouncycastle.version>1.78.1</bouncycastle.version>
+    <caffeine.version>2.9.3</caffeine.version>
     <calcite.groupId>org.apache.calcite</calcite.groupId>
     <calcite.version>1.34.0</calcite.version>
     <codemodel.version>2.6</codemodel.version>