Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](jdbc catalog) Use factory methods to return mapped types instead #46623 #46673

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2025

Cherry-picked from #46623

#46623)

We should use factory methods to create types instead of returning a type directly, because the returned type is static and final, which will cause problems with length setting.
@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 9, 2025
@dataroaring dataroaring reopened this Jan 9, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41408 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 37e8d80080cde9c8f90fb6a2a489d69e9f1bb239, data reload: false

------ Round 1 ----------------------------------
q1	17718	7436	7295	7295
q2	2079	165	160	160
q3	10677	1153	1177	1153
q4	10657	736	764	736
q5	8148	2938	2860	2860
q6	238	144	143	143
q7	987	625	611	611
q8	9887	2008	2036	2008
q9	6813	6521	6528	6521
q10	7921	2332	2343	2332
q11	477	264	260	260
q12	413	207	205	205
q13	17804	3025	3018	3018
q14	243	219	219	219
q15	567	531	548	531
q16	717	592	622	592
q17	976	562	564	562
q18	7428	6772	6683	6683
q19	1397	1029	1101	1029
q20	449	202	193	193
q21	4101	3327	3353	3327
q22	1088	970	994	970
Total cold run time: 110785 ms
Total hot run time: 41408 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7358	7223	7212	7212
q2	333	235	267	235
q3	3197	3000	2889	2889
q4	2043	1881	1837	1837
q5	5731	5788	5788	5788
q6	223	134	135	134
q7	2259	1768	1832	1768
q8	3321	3510	3483	3483
q9	8932	9071	8848	8848
q10	3634	3548	3540	3540
q11	585	504	503	503
q12	846	644	623	623
q13	4303	3119	3056	3056
q14	286	255	252	252
q15	573	514	500	500
q16	706	671	660	660
q17	1785	1578	1550	1550
q18	7970	7375	7374	7374
q19	1655	1511	1603	1511
q20	2051	1828	1774	1774
q21	5273	5182	5119	5119
q22	1127	1010	989	989
Total cold run time: 64191 ms
Total hot run time: 59645 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191350 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 37e8d80080cde9c8f90fb6a2a489d69e9f1bb239, data reload: false

query1	961	373	359	359
query2	6525	2180	2090	2090
query3	6705	226	225	225
query4	33772	23353	23453	23353
query5	4359	467	456	456
query6	291	186	184	184
query7	4632	320	315	315
query8	298	233	232	232
query9	9386	2695	2695	2695
query10	475	267	260	260
query11	17976	15192	15321	15192
query12	151	106	103	103
query13	1659	428	423	423
query14	10080	7313	6742	6742
query15	272	172	181	172
query16	8197	448	463	448
query17	1683	582	565	565
query18	2152	327	306	306
query19	374	151	149	149
query20	117	103	108	103
query21	206	105	98	98
query22	4368	4427	4330	4330
query23	34780	33975	33908	33908
query24	11213	2825	2841	2825
query25	649	390	392	390
query26	1244	169	167	167
query27	2901	352	344	344
query28	7923	2440	2427	2427
query29	864	436	429	429
query30	330	161	163	161
query31	1019	785	795	785
query32	96	57	57	57
query33	793	290	289	289
query34	960	492	502	492
query35	841	707	691	691
query36	1129	952	980	952
query37	132	74	72	72
query38	4014	3878	3870	3870
query39	1500	1459	1436	1436
query40	207	97	101	97
query41	52	49	50	49
query42	114	96	101	96
query43	522	503	487	487
query44	1203	802	798	798
query45	184	166	169	166
query46	1147	701	727	701
query47	1926	1806	1834	1806
query48	467	375	386	375
query49	1170	389	392	389
query50	814	408	408	408
query51	7239	7106	7232	7106
query52	101	95	92	92
query53	254	186	181	181
query54	1344	469	463	463
query55	79	78	81	78
query56	289	260	256	256
query57	1219	1110	1113	1110
query58	252	209	219	209
query59	3178	3020	2917	2917
query60	309	274	268	268
query61	170	135	133	133
query62	900	696	668	668
query63	228	188	191	188
query64	5391	750	740	740
query65	3309	3234	3184	3184
query66	1471	336	333	333
query67	15876	15773	15452	15452
query68	4870	586	568	568
query69	456	268	275	268
query70	1156	1137	1131	1131
query71	350	270	266	266
query72	6616	4110	4138	4110
query73	763	346	344	344
query74	10447	9019	8864	8864
query75	3429	2579	2645	2579
query76	2919	1080	1080	1080
query77	441	273	272	272
query78	10464	9651	9524	9524
query79	2185	595	595	595
query80	1189	425	417	417
query81	583	247	238	238
query82	938	118	112	112
query83	216	150	141	141
query84	237	78	77	77
query85	1337	300	290	290
query86	434	296	306	296
query87	4393	4303	4259	4259
query88	3962	2360	2359	2359
query89	405	292	291	291
query90	2034	184	183	183
query91	182	151	153	151
query92	68	53	52	52
query93	1714	563	547	547
query94	926	306	300	300
query95	352	254	253	253
query96	610	278	272	272
query97	3331	3208	3174	3174
query98	215	206	191	191
query99	1533	1314	1301	1301
Total cold run time: 303197 ms
Total hot run time: 191350 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 37e8d80080cde9c8f90fb6a2a489d69e9f1bb239, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.63	0.10	0.10
query5	0.54	0.52	0.52
query6	1.14	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.57	0.52	0.51
query10	0.55	0.56	0.54
query11	0.15	0.10	0.10
query12	0.15	0.11	0.10
query13	0.61	0.60	0.58
query14	3.04	2.93	3.02
query15	0.90	0.82	0.82
query16	0.38	0.38	0.38
query17	1.02	0.99	0.99
query18	0.23	0.22	0.21
query19	1.96	1.92	2.00
query20	0.01	0.02	0.01
query21	15.35	0.58	0.57
query22	2.81	2.19	1.75
query23	17.04	1.02	0.74
query24	3.83	1.90	1.31
query25	0.27	0.19	0.06
query26	0.48	0.14	0.14
query27	0.05	0.04	0.05
query28	9.41	1.11	1.08
query29	12.59	3.21	3.30
query30	0.24	0.06	0.06
query31	2.86	0.39	0.39
query32	3.24	0.45	0.47
query33	2.96	3.04	3.05
query34	17.27	4.50	4.52
query35	4.51	4.44	4.50
query36	0.68	0.50	0.48
query37	0.09	0.06	0.07
query38	0.04	0.03	0.03
query39	0.04	0.02	0.03
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.34 s
Total hot run time: 33.17 s

@morningman morningman merged commit 2231f4c into branch-3.0 Jan 9, 2025
22 checks passed
@github-actions github-actions bot deleted the auto-pick-46623-branch-3.0 branch January 9, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants