-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](partial update) Fix incorrect result when partial update include delete sign columns #46194
[Fix](partial update) Fix incorrect result when partial update include delete sign columns #46194
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 33579 ms
|
TPC-DS: Total hot run time: 196779 ms
|
ClickBench: Total hot run time: 32.03 s
|
TeamCity be ut coverage result: |
run buildall |
41c458f
to
f35cad9
Compare
run buildall |
TPC-H: Total hot run time: 32492 ms
|
TPC-DS: Total hot run time: 190883 ms
|
ClickBench: Total hot run time: 31.25 s
|
TeamCity be ut coverage result: |
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…e delete sign columns (apache#46194) Currently, when a partial update load include delete sign columns, it will not read delete sign columns from historical data. This may result in incorrect result because it may read data from rows whose delete sign is 1.
What problem does this PR solve?
Problem Summary:
Currently, when a partial update load include delete sign columns, it will not read delete sign columns from historical data. This may result in incorrect result because it may read data from rows whose delete sign is 1.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)