Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enchement](utf8)import enable_text_validate_utf8 session var (#45537) #46070

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Dec 27, 2024

bp #45537
Problem Summary:
When reading text format files in Hive catalog and TVF, sometimes you may encounter the exception Only support csv data in utf8 codec. I introduced a new session variable enable_text_validate_utf8 to control whether to check the utf8 format.

Release note

Introduced enable_text_validate_utf8 session variable to control whether to check the utf8 format.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…#45537)

Problem Summary:
When reading text format files in Hive catalog and TVF, sometimes you
may encounter the exception `Only support csv data in utf8 codec`.
I introduced a new session variable `enable_text_validate_utf8` to
control whether to check the utf8 format.

Introduced `enable_text_validate_utf8` session variable to control
whether to check the utf8 format.
@Thearas
Copy link
Contributor

Thearas commented Dec 27, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.39% (9540/26218)
Line Coverage: 27.89% (78573/281710)
Region Coverage: 26.56% (40326/151825)
Branch Coverage: 23.32% (20422/87580)
Coverage Report: http://coverage.selectdb-in.cc/coverage/662ebbcd28d98b387da583d12bd6dff4a795bfec_662ebbcd28d98b387da583d12bd6dff4a795bfec/report/index.html

@hubgeter
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.38% (9538/26219)
Line Coverage: 27.89% (78571/281752)
Region Coverage: 26.56% (40336/151859)
Branch Coverage: 23.32% (20428/87608)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2cb72a05d84b95ee34e15c4105527fed510805c3_2cb72a05d84b95ee34e15c4105527fed510805c3/report/index.html

@morningman morningman merged commit a380f5d into apache:branch-2.1 Dec 28, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants