-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](Nereids) refactor the parsing way of date series functions #46037
Merged
+1,082
−370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morrySnow
force-pushed
the
fix_quote_date_sub
branch
from
December 26, 2024 10:10
0707c99
to
0dcd609
Compare
run buildall |
TPC-H: Total hot run time: 32409 ms
|
TPC-DS: Total hot run time: 189477 ms
|
ClickBench: Total hot run time: 31.83 s
|
morrySnow
force-pushed
the
fix_quote_date_sub
branch
from
December 26, 2024 11:25
0dcd609
to
01b3113
Compare
run buildall |
TPC-H: Total hot run time: 32733 ms
|
TPC-DS: Total hot run time: 196058 ms
|
ClickBench: Total hot run time: 31.44 s
|
morrySnow
force-pushed
the
fix_quote_date_sub
branch
from
December 26, 2024 15:25
01b3113
to
64222a9
Compare
run buildall |
TPC-H: Total hot run time: 32945 ms
|
TPC-DS: Total hot run time: 190531 ms
|
ClickBench: Total hot run time: 30.97 s
|
morrySnow
force-pushed
the
fix_quote_date_sub
branch
from
December 27, 2024 04:07
64222a9
to
7617f0b
Compare
run buildall |
TPC-H: Total hot run time: 32605 ms
|
TPC-DS: Total hot run time: 191042 ms
|
ClickBench: Total hot run time: 31.62 s
|
morrySnow
force-pushed
the
fix_quote_date_sub
branch
from
December 27, 2024 05:47
7617f0b
to
b9d218f
Compare
run buildall |
TPC-H: Total hot run time: 32335 ms
|
morrySnow
force-pushed
the
fix_quote_date_sub
branch
from
December 27, 2024 06:40
b9d218f
to
368bb2d
Compare
TPC-DS: Total hot run time: 197579 ms
|
run buildall |
TPC-H: Total hot run time: 32326 ms
|
TPC-DS: Total hot run time: 196474 ms
|
ClickBench: Total hot run time: 32.18 s
|
starocean999
approved these changes
Dec 27, 2024
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Dec 27, 2024
PR approved by anyone and no changes requested. |
englefly
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.x
dev/2.1.x-conflict
dev/3.0.x
dev/3.0.x-conflict
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Previously, we use specific syntex to process date_add, date_sub, etc.. In this way, we could not process quoted function name. From now on, we use generic way to parse these functions, and introduce a sepcific function binder to process them.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)