-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](nerieds)Push encode slot #45958
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 32294 ms
|
run buildall |
TPC-H: Total hot run time: 32710 ms
|
TPC-DS: Total hot run time: 196471 ms
|
ClickBench: Total hot run time: 31.89 s
|
run buildall |
TPC-H: Total hot run time: 32946 ms
|
run p0 |
1 similar comment
run p0 |
run buildall |
TPC-H: Total hot run time: 32433 ms
|
f3c51e9
to
0535a37
Compare
run buildall |
TPC-H: Total hot run time: 25486 ms
|
TPC-DS: Total hot run time: 186159 ms
|
ClickBench: Total hot run time: 31.11 s
|
run buildall |
TPC-H: Total hot run time: 25269 ms
|
run buildall |
TPC-H: Total hot run time: 25096 ms
|
TPC-DS: Total hot run time: 161767 ms
|
ClickBench: Total hot run time: 31.54 s
|
run buildall |
TPC-H: Total hot run time: 25448 ms
|
TPC-DS: Total hot run time: 181154 ms
|
ClickBench: Total hot run time: 30.69 s
|
ccdf5b6
to
6509c3b
Compare
run buildall |
TPC-H: Total hot run time: 32246 ms
|
TPC-DS: Total hot run time: 197229 ms
|
ClickBench: Total hot run time: 32.01 s
|
run p0 |
1 similar comment
run p0 |
run cloud_p0 |
run buildall |
TPC-H: Total hot run time: 32533 ms
|
TPC-DS: Total hot run time: 197000 ms
|
ClickBench: Total hot run time: 31.58 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
@@ -114,6 +114,10 @@ public enum RuleType { | |||
// rewrite rules | |||
COMPRESSED_MATERIALIZE_AGG(RuleTypeClass.REWRITE), | |||
COMPRESSED_MATERIALIZE_SORT(RuleTypeClass.REWRITE), | |||
COMPRESSED_MATERIALIZE_REPEAT(RuleTypeClass.REWRITE), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inactive in this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REPEAT node has a strict requirement, which is not good. I plan to add rule for repeat and drop that requirement in future
NamedExpression replacedExpr = (NamedExpression) | ||
expr.rewriteUp(e -> plan1ToPlan2.getOrDefault(e, e)); | ||
if (!replacedExpr.equals(((LogicalProject<?>) plan2).getProjects().get(i))) { | ||
Expression expr1 = ((LogicalProject<?>) plan1).getProjects().get(i); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a bug fix? what's the scenario the bug can reproduce?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. tpcds q4. This is double checked by @feiniaofeiafei
/** | ||
* push down encode slot | ||
*/ | ||
public static class EncodeSlotPushDownVisitor extends PlanVisitor<Plan, PushDownContext> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about window function visitor? is there any necessary to handle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
window function has lower priority, not implemented now.
only group-by and sort/topn is supported in this version
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)