Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](ShortCircuit) fix prepared statement with partial arguments prepared (#45371) #45732

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[Fix](ShortCircuit) fix prepared statement with partial arguments prepared (#45371) #45732

merged 1 commit into from
Dec 23, 2024
+160 −33

Conversation

eldenmoon
Copy link
Member

(#45371)

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon
[Fix](ShortCircuit) fix prepared statement with partial arguments pre…
b8ce691 
…pared (apache#45371)

We should record the placehold id map to both real Expr and the slot of
conjuncts.Otherwise the info is lost, and lead to the conjuncts updated
in wrong order(`updateScanNodeConjuncts`)
@eldenmoon
Copy link
Member Author

run buildall

@yiguolei yiguolei merged commit ca9f0ad into apache:branch-2.1 Dec 23, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldenmoon @hello-stephen @yiguolei