Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix](ccr) Wrong result of tosql for add column with comment #45319 #45726

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

wyxxxcat
Copy link
Contributor

pick : #45319

@Thearas
Copy link
Contributor

Thearas commented Dec 20, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40738 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e560609ac2f086cbc4da2fe86e93529209ea5c3, data reload: false

------ Round 1 ----------------------------------
q1	17564	7432	7277	7277
q2	2063	172	160	160
q3	10718	1571	1135	1135
q4	10568	769	755	755
q5	7752	2853	2783	2783
q6	232	150	150	150
q7	972	622	639	622
q8	9672	1988	2012	1988
q9	8162	6447	6452	6447
q10	7135	2294	2277	2277
q11	461	268	265	265
q12	414	218	218	218
q13	17792	2997	2963	2963
q14	245	206	204	204
q15	551	513	510	510
q16	689	631	619	619
q17	952	505	529	505
q18	7161	6642	6613	6613
q19	1371	992	990	990
q20	468	197	200	197
q21	3975	3200	3088	3088
q22	1115	1005	972	972
Total cold run time: 110032 ms
Total hot run time: 40738 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7287	7265	7274	7265
q2	325	234	224	224
q3	3008	2852	2854	2852
q4	2038	1784	1757	1757
q5	5624	5671	5645	5645
q6	224	146	149	146
q7	2180	1778	1752	1752
q8	3306	3493	3441	3441
q9	8721	8783	8737	8737
q10	3540	3526	3466	3466
q11	584	504	488	488
q12	774	619	604	604
q13	15055	3154	3143	3143
q14	323	263	271	263
q15	561	512	532	512
q16	728	656	668	656
q17	1801	1617	1553	1553
q18	8270	7865	7366	7366
q19	7331	1518	1547	1518
q20	2045	1864	1844	1844
q21	5509	5403	5316	5316
q22	1116	1062	1027	1027
Total cold run time: 80350 ms
Total hot run time: 59575 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196501 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e560609ac2f086cbc4da2fe86e93529209ea5c3, data reload: false

query1	1261	923	931	923
query2	6201	2224	2131	2131
query3	10967	4181	4117	4117
query4	66268	30240	23660	23660
query5	5265	447	448	447
query6	460	175	180	175
query7	5653	301	298	298
query8	300	212	221	212
query9	9396	2668	2653	2653
query10	506	256	253	253
query11	17793	15172	15767	15172
query12	161	100	108	100
query13	1547	439	422	422
query14	11266	7337	7027	7027
query15	210	182	181	181
query16	7755	517	537	517
query17	1078	571	542	542
query18	1917	309	295	295
query19	211	152	148	148
query20	116	108	108	108
query21	68	42	42	42
query22	4867	4587	4525	4525
query23	34836	34037	34198	34037
query24	6147	2901	2989	2901
query25	527	394	382	382
query26	680	178	166	166
query27	1935	299	295	295
query28	4348	2537	2496	2496
query29	669	426	442	426
query30	250	158	160	158
query31	997	818	832	818
query32	73	58	55	55
query33	485	283	288	283
query34	921	503	508	503
query35	847	736	765	736
query36	1086	955	968	955
query37	125	71	71	71
query38	4128	4019	4056	4019
query39	1537	1471	1502	1471
query40	146	83	84	83
query41	49	52	50	50
query42	116	105	104	104
query43	544	499	501	499
query44	1154	801	801	801
query45	187	174	174	174
query46	1166	717	732	717
query47	1993	1926	1947	1926
query48	463	384	372	372
query49	767	387	391	387
query50	835	431	433	431
query51	7322	7266	7078	7078
query52	101	85	95	85
query53	258	184	184	184
query54	574	450	450	450
query55	75	73	78	73
query56	259	254	274	254
query57	1193	1128	1119	1119
query58	217	202	210	202
query59	3313	2938	3187	2938
query60	276	259	256	256
query61	127	128	135	128
query62	769	658	664	658
query63	205	184	180	180
query64	1776	640	604	604
query65	3270	3177	3151	3151
query66	719	298	295	295
query67	15927	15536	15560	15536
query68	4590	543	543	543
query69	441	258	246	246
query70	1207	1120	1120	1120
query71	408	264	246	246
query72	6527	4003	3844	3844
query73	772	342	339	339
query74	10167	8944	9048	8944
query75	3375	2634	2641	2634
query76	2059	1054	1041	1041
query77	484	269	276	269
query78	10845	9748	9579	9579
query79	6596	586	586	586
query80	1987	417	415	415
query81	551	247	236	236
query82	945	114	114	114
query83	261	145	147	145
query84	287	87	78	78
query85	1788	294	284	284
query86	496	301	274	274
query87	4471	4300	4178	4178
query88	5384	2347	2373	2347
query89	407	284	287	284
query90	2048	178	176	176
query91	179	143	145	143
query92	67	46	48	46
query93	5825	524	516	516
query94	892	298	275	275
query95	350	245	239	239
query96	640	275	281	275
query97	3418	3155	3147	3147
query98	214	193	194	193
query99	1807	1314	1290	1290
Total cold run time: 336146 ms
Total hot run time: 196501 ms

@dataroaring dataroaring merged commit 82f497c into apache:branch-3.0 Dec 23, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants