Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](nereids)use equals instead of == to compare String #45628 #45707

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45628

when comparing column name, we should use equals method instead of '=='
to compare the content
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 20, 2024
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40266 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9463c23378578f184ea8dadcbf8662522a3a0b8, data reload: false

------ Round 1 ----------------------------------
q1	17592	7392	7320	7320
q2	2072	170	159	159
q3	10703	1063	1123	1063
q4	10545	761	815	761
q5	7728	2787	2801	2787
q6	236	151	139	139
q7	971	605	597	597
q8	9342	1945	1927	1927
q9	6567	6352	6459	6352
q10	7004	2268	2254	2254
q11	454	260	260	260
q12	401	212	203	203
q13	17782	2951	2967	2951
q14	231	209	201	201
q15	551	506	525	506
q16	687	602	603	602
q17	971	501	514	501
q18	7253	6696	6478	6478
q19	1377	1084	973	973
q20	486	201	191	191
q21	3917	3204	3056	3056
q22	1099	996	985	985
Total cold run time: 107969 ms
Total hot run time: 40266 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7294	7243	7274	7243
q2	320	229	232	229
q3	2867	2794	2782	2782
q4	1996	1751	1779	1751
q5	5658	5666	5727	5666
q6	223	143	140	140
q7	2173	1748	1715	1715
q8	3374	3530	3519	3519
q9	8709	8796	8913	8796
q10	3576	3466	3498	3466
q11	589	508	498	498
q12	805	592	610	592
q13	15736	3131	3088	3088
q14	302	270	285	270
q15	570	533	513	513
q16	694	669	655	655
q17	1836	1645	1621	1621
q18	8282	7703	7711	7703
q19	6672	1547	1568	1547
q20	2015	1816	1848	1816
q21	5456	5269	5185	5185
q22	1118	1015	1038	1015
Total cold run time: 80265 ms
Total hot run time: 59810 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194954 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9463c23378578f184ea8dadcbf8662522a3a0b8, data reload: false

query1	1309	879	877	877
query2	6244	2198	2117	2117
query3	11017	4253	3997	3997
query4	61377	30100	23554	23554
query5	5171	452	465	452
query6	412	181	178	178
query7	5679	309	310	309
query8	316	232	233	232
query9	9396	2663	2651	2651
query10	514	277	276	276
query11	18149	15059	15619	15059
query12	157	99	101	99
query13	1561	457	417	417
query14	10912	6912	6708	6708
query15	217	177	175	175
query16	7251	502	473	473
query17	1182	570	565	565
query18	1962	301	308	301
query19	234	156	149	149
query20	118	109	109	109
query21	56	40	42	40
query22	4585	4891	4452	4452
query23	34671	33871	33970	33871
query24	6176	2895	2804	2804
query25	526	379	386	379
query26	666	167	163	163
query27	1801	298	301	298
query28	4401	2565	2526	2526
query29	707	435	421	421
query30	246	172	166	166
query31	979	803	809	803
query32	62	55	54	54
query33	453	271	271	271
query34	920	491	491	491
query35	841	740	737	737
query36	1090	930	962	930
query37	116	70	73	70
query38	4050	3927	3984	3927
query39	1542	1509	1453	1453
query40	141	78	84	78
query41	49	47	45	45
query42	115	96	98	96
query43	562	511	505	505
query44	1147	785	781	781
query45	186	169	174	169
query46	1173	741	715	715
query47	2002	1909	1918	1909
query48	445	365	376	365
query49	719	385	401	385
query50	839	415	411	411
query51	7282	7078	7207	7078
query52	102	102	90	90
query53	286	183	183	183
query54	567	468	480	468
query55	93	80	85	80
query56	270	251	239	239
query57	1247	1166	1202	1166
query58	218	217	217	217
query59	3281	3094	2864	2864
query60	282	262	267	262
query61	129	122	125	122
query62	769	655	672	655
query63	211	180	184	180
query64	1831	722	729	722
query65	3278	3169	3205	3169
query66	680	292	291	291
query67	15907	15435	15335	15335
query68	4456	531	545	531
query69	428	253	254	253
query70	1168	1052	1100	1052
query71	358	250	247	247
query72	6519	3908	3938	3908
query73	754	343	340	340
query74	10058	8959	8799	8799
query75	3319	2635	2644	2635
query76	2074	1064	998	998
query77	546	265	261	261
query78	10877	9711	9511	9511
query79	8016	587	576	576
query80	2166	413	411	411
query81	567	237	237	237
query82	1175	115	115	115
query83	302	138	141	138
query84	293	73	77	73
query85	1244	322	289	289
query86	444	296	281	281
query87	4466	4214	4292	4214
query88	5516	2368	2414	2368
query89	414	292	288	288
query90	2026	186	190	186
query91	177	141	144	141
query92	59	50	47	47
query93	6734	531	516	516
query94	885	286	290	286
query95	352	249	251	249
query96	625	276	288	276
query97	3345	3117	3139	3117
query98	210	201	196	196
query99	1616	1281	1281	1281
Total cold run time: 332066 ms
Total hot run time: 194954 ms

@starocean999 starocean999 merged commit cb21741 into branch-3.0 Dec 23, 2024
19 of 21 checks passed
@github-actions github-actions bot deleted the auto-pick-45628-branch-3.0 branch December 23, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants