-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](vault) Fix bugs about altering storage vault name #45685
base: master
Are you sure you want to change the base?
Conversation
* fix altering storage name but not writing disk in meta-service * check vault if existed when altering stoarge vault name
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
return false; | ||
} | ||
|
||
static int alter_hdfs_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction>& txn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'alter_hdfs_storage_vault' exceeds recommended size/complexity thresholds [readability-function-size]
static int alter_hdfs_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction>& txn,
^
Additional context
cloud/src/meta-service/meta_service_resource.cpp:534: 116 lines including whitespace and comments (threshold 80)
static int alter_hdfs_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction>& txn,
^
return 0; | ||
} | ||
|
||
static int alter_s3_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction> txn, | ||
static int alter_s3_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction>& txn, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function 'alter_s3_storage_vault' exceeds recommended size/complexity thresholds [readability-function-size]
static int alter_s3_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction>& txn,
^
Additional context
cloud/src/meta-service/meta_service_resource.cpp:654: 130 lines including whitespace and comments (threshold 80)
static int alter_s3_storage_vault(InstanceInfoPB& instance, std::unique_ptr<Transaction>& txn,
^
TPC-H: Total hot run time: 39897 ms
|
TPC-DS: Total hot run time: 196967 ms
|
ClickBench: Total hot run time: 33.53 s
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)