-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](cloud-mow) FE should release delete bitmap lock when calculating delete bitmap failed #45673
base: master
Are you sure you want to change the base?
Conversation
…g delete bitmap failed
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 39978 ms
|
TPC-DS: Total hot run time: 196410 ms
|
ClickBench: Total hot run time: 32.36 s
|
@@ -1187,6 +1189,10 @@ public boolean commitAndPublishTransaction(DatabaseIf db, List<Table> tableList, | |||
beforeCommitTransaction(tableList, transactionId, timeoutMillis); | |||
try { | |||
commitTransaction(db.getId(), tableList, transactionId, tabletCommitInfos, txnCommitAttachment); | |||
} catch (Exception e) { | |||
LOG.info("release delete bitmap lock,commit txn=" + transactionId + ",catch exception=" + e.getMessage()); | |||
removeDeleteBitmapUpdateLock(tableList, transactionId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'd better to call getDeleteBitmapUpdateLock
and removeDeleteBitmapUpdateLock
in the same function.
run buildall |
run buildall |
run buildall |
TPC-H: Total hot run time: 39923 ms
|
TPC-DS: Total hot run time: 196693 ms
|
ClickBench: Total hot run time: 32.82 s
|
run buildall |
TPC-H: Total hot run time: 39654 ms
|
TPC-DS: Total hot run time: 190121 ms
|
ClickBench: Total hot run time: 32.82 s
|
When calculating delete bitmap failed, delete bitmap lock is holded by last failed txn, fe should release lock for other txn can do commit.
Issue Number: close #xxx
Related PR: #41759
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)