[fix](catelog) Unifies partition items string #45669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For range parttion, `getItems().toString()` is equals to `getItemsString` , but for list partition, there has a `,` between each item
w41ter
requested review from
dataroaring,
CalvinKirs and
morningman
as code owners
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Dec 20, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: For range partitions, `getItems().toString()` is equal to `getItemsString`, but for list partitions, there has a `,` between each item. The upsert record of binlog is generated via `getItemsString`, but the getMeta method fetches partition items string via `getItems().toString()`, which are different in the list partitions, and the ccr-syncer is unable to identify them. This PR unifies all partition items string via `getItemsString`.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: For range partitions, `getItems().toString()` is equal to `getItemsString`, but for list partitions, there has a `,` between each item. The upsert record of binlog is generated via `getItemsString`, but the getMeta method fetches partition items string via `getItems().toString()`, which are different in the list partitions, and the ccr-syncer is unable to identify them. This PR unifies all partition items string via `getItemsString`.
w41ter
added a commit
that referenced
this pull request
Dec 20, 2024
### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: For range partitions, `getItems().toString()` is equal to `getItemsString`, but for list partitions, there has a `,` between each item. The upsert record of binlog is generated via `getItemsString`, but the getMeta method fetches partition items string via `getItems().toString()`, which are different in the list partitions, and the ccr-syncer is unable to identify them. This PR unifies all partition items string via `getItemsString`.
w41ter
added a commit
that referenced
this pull request
Dec 23, 2024
) Cherry-picked from #45669 --------- Co-authored-by: walter <[email protected]>
w41ter
added a commit
that referenced
this pull request
Dec 23, 2024
) Cherry-picked from #45669 Co-authored-by: walter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
For range partitions,
getItems().toString()is equal togetItemsString, but for list partitions, there has a,between each item.The upsert record of binlog is generated via
getItemsString, but the getMeta method fetches partition items string viagetItems().toString(), which are different in the list partitions, and the ccr-syncer is unable to identify them.This PR unifies all partition items string via
getItemsString.Release note
None
Check List (For Author)
The test in the ccr part: selectdb/ccr-syncer#339
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)