Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](log) remove useless resource id log on write path #45618

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[chore](log) remove useless resource id log on write path #45618

merged 2 commits into from
Dec 23, 2024

Conversation

dataroaring
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei previously approved these changes Dec 19, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

gavinchou
gavinchou previously approved these changes Dec 19, 2024
View reviewed changes
gavinchou
gavinchou reviewed Dec 19, 2024
View reviewed changes
be/src/cloud/cloud_storage_engine.h Outdated
@@ -75,7 +75,7 @@ class CloudStorageEngine final : public BaseStorageEngine {
void _check_file_cache_ttl_block_valid();

std::optional<StorageResource> get_storage_resource(const std::string& vault_id) {
LOG(INFO) << "Getting storage resource for vault_id: " << vault_id;
LOG(DEBUG) << "Getting storage resource for vault_id: " << vault_id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VLOG()

@gavinchou gavinchou dismissed stale reviews from yiguolei and themself via 2c0f80d December 19, 2024 15:12
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 19, 2024
@dataroaring
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.87% (10131/26061)
Line Coverage: 29.79% (85168/285936)
Region Coverage: 28.90% (43452/150363)
Branch Coverage: 25.43% (22152/87120)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2c0f80d219cdcb063423e9ce56e4ee55e96ec0c2_2c0f80d219cdcb063423e9ce56e4ee55e96ec0c2/report/index.html

@gavinchou gavinchou changed the title [chore](log) remove useless log [chore](log) remove useless resource id log on write path Dec 23, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit 1853d15 into apache:master Dec 23, 2024
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
@dataroaring
[chore](log) remove useless resource id log on write path (#45618)
043417f
@github-actions github-actions bot mentioned this pull request Dec 23, 2024
Merged
dataroaring added a commit that referenced this pull request Dec 25, 2024
@github-actions @dataroaring
branch-3.0: [chore](log) remove useless resource id log on write path #…
7e12a74 
…45618 (#45807)

Cherry-picked from #45618

Co-authored-by: Yongqiang YANG <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

@gavinchou gavinchou gavinchou approved these changes

@yiguolei yiguolei yiguolei left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dataroaring @Thearas @doris-robot @gavinchou @yiguolei @Yukang-Lian