Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[revert](memory) Revert disable Jemalloc Hook #45507

Closed
wants to merge 1 commit into from

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Dec 17, 2024

What problem does this PR solve?

It is not easy to remove with-jemalloc-prefix, which may affect the compatibility between third-party and old version codes.
Also, will building failed on Mac, it said can't find mallctl symbol. because jemalloc's default prefix on macOS is "je_", not "".

Maybe can use alias instead of override.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xinyiZzz
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.85% (10127/26064)
Line Coverage: 29.78% (85135/285897)
Region Coverage: 28.82% (43653/151490)
Branch Coverage: 25.36% (22176/87450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/068d5bb2a76def1c251d2459cf48a4840056ca3a_068d5bb2a76def1c251d2459cf48a4840056ca3a/report/index.html

@xinyiZzz xinyiZzz closed this Dec 17, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 39985 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 068d5bb2a76def1c251d2459cf48a4840056ca3a, data reload: false

------ Round 1 ----------------------------------
q1	17879	7532	7318	7318
q2	2063	181	179	179
q3	10829	1077	1219	1077
q4	10333	720	728	720
q5	7619	2775	2738	2738
q6	240	147	144	144
q7	978	629	607	607
q8	9228	1904	1942	1904
q9	6784	6565	6573	6565
q10	7042	2278	2347	2278
q11	473	258	247	247
q12	433	227	221	221
q13	17836	2975	3009	2975
q14	237	204	215	204
q15	578	528	522	522
q16	661	587	587	587
q17	1014	528	504	504
q18	7264	6720	6645	6645
q19	1361	987	995	987
q20	474	181	179	179
q21	4090	3201	3075	3075
q22	379	324	309	309
Total cold run time: 107795 ms
Total hot run time: 39985 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7245	7197	7210	7197
q2	330	230	223	223
q3	2949	2832	2914	2832
q4	2053	1853	1895	1853
q5	5711	5701	5674	5674
q6	225	144	145	144
q7	2258	1830	1782	1782
q8	3418	3602	3522	3522
q9	8964	9121	9102	9102
q10	3633	3523	3554	3523
q11	596	517	500	500
q12	844	604	610	604
q13	10208	3235	3276	3235
q14	293	285	264	264
q15	577	538	523	523
q16	701	673	653	653
q17	1888	1626	1586	1586
q18	8327	7847	7791	7791
q19	1751	1668	1603	1603
q20	2113	1870	1896	1870
q21	5597	5455	5359	5359
q22	653	594	590	590
Total cold run time: 70334 ms
Total hot run time: 60430 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195940 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 068d5bb2a76def1c251d2459cf48a4840056ca3a, data reload: false

query1	1310	977	911	911
query2	6255	2114	2014	2014
query3	11042	4442	4371	4371
query4	67870	28409	23483	23483
query5	4977	466	457	457
query6	408	200	198	198
query7	5482	322	297	297
query8	327	234	233	233
query9	8653	2616	2638	2616
query10	437	246	262	246
query11	17076	15177	15789	15177
query12	153	111	105	105
query13	1485	452	440	440
query14	10478	7284	6672	6672
query15	225	196	198	196
query16	7143	481	506	481
query17	1060	574	569	569
query18	2058	300	299	299
query19	205	165	150	150
query20	122	110	131	110
query21	209	110	108	108
query22	4664	4560	4657	4560
query23	34560	33912	33843	33843
query24	5415	2582	2394	2394
query25	497	386	398	386
query26	653	155	150	150
query27	1749	279	283	279
query28	4494	2438	2469	2438
query29	673	440	421	421
query30	205	151	154	151
query31	1026	846	851	846
query32	64	55	57	55
query33	442	287	288	287
query34	971	531	520	520
query35	854	783	748	748
query36	1121	964	958	958
query37	118	74	72	72
query38	4472	4378	4239	4239
query39	1518	1450	1492	1450
query40	203	103	101	101
query41	46	44	44	44
query42	119	102	100	100
query43	538	514	513	513
query44	1184	846	846	846
query45	186	171	172	171
query46	1170	714	716	714
query47	2073	1973	1977	1973
query48	448	332	345	332
query49	725	388	400	388
query50	849	387	393	387
query51	7496	7233	7191	7191
query52	100	91	86	86
query53	252	175	178	175
query54	519	412	390	390
query55	79	74	78	74
query56	247	250	238	238
query57	1254	1130	1117	1117
query58	230	211	223	211
query59	3293	3340	3084	3084
query60	282	248	250	248
query61	107	106	148	106
query62	799	663	667	663
query63	211	186	188	186
query64	1382	668	657	657
query65	3267	3197	3176	3176
query66	708	292	313	292
query67	16052	15563	15681	15563
query68	4285	591	572	572
query69	445	260	243	243
query70	1200	1149	1136	1136
query71	359	247	242	242
query72	6456	4051	4069	4051
query73	783	360	366	360
query74	9417	8928	8900	8900
query75	3362	2650	2626	2626
query76	1942	1186	1058	1058
query77	501	273	275	273
query78	10389	9459	9466	9459
query79	1434	593	594	593
query80	856	516	428	428
query81	490	228	232	228
query82	911	115	125	115
query83	161	139	156	139
query84	285	71	67	67
query85	845	312	300	300
query86	338	294	299	294
query87	4614	4502	4625	4502
query88	3589	2217	2188	2188
query89	420	286	337	286
query90	2014	190	185	185
query91	132	103	107	103
query92	71	50	51	50
query93	1559	551	567	551
query94	788	297	293	293
query95	346	252	245	245
query96	613	282	283	282
query97	2842	2718	2688	2688
query98	216	204	202	202
query99	1552	1325	1334	1325
Total cold run time: 317505 ms
Total hot run time: 195940 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 068d5bb2a76def1c251d2459cf48a4840056ca3a, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.08	0.07
query4	1.62	0.11	0.11
query5	0.42	0.39	0.41
query6	1.19	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.52
query10	0.55	0.58	0.56
query11	0.15	0.11	0.10
query12	0.15	0.11	0.10
query13	0.61	0.61	0.60
query14	2.74	2.90	2.71
query15	0.89	0.83	0.81
query16	0.39	0.38	0.38
query17	1.08	1.01	0.97
query18	0.22	0.21	0.21
query19	1.80	1.80	1.87
query20	0.02	0.01	0.01
query21	15.39	0.59	0.57
query22	2.28	2.23	1.38
query23	17.05	1.01	0.89
query24	2.84	1.86	1.03
query25	0.17	0.26	0.11
query26	0.48	0.15	0.13
query27	0.04	0.04	0.05
query28	10.31	1.10	1.07
query29	12.59	3.27	3.24
query30	0.24	0.06	0.08
query31	2.85	0.39	0.38
query32	3.26	0.46	0.46
query33	3.08	3.14	3.07
query34	17.04	4.57	4.54
query35	4.61	4.57	4.57
query36	0.69	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.07	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.22 s
Total hot run time: 32.41 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants