Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 #45467

Merged
merged 1 commit into from
Dec 23, 2024
Merged

branch-3.0: [feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to start quickly #45267 #45467

merged 1 commit into from
Dec 23, 2024
+10 −0

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45267

@FreeOnePlus
[feat](docker)Add a BE ENV item 'SKIP_CHECK_ULIMIT' for Docker to sta…
43d54fe 
…rt quickly (#45267)

In the storage_engine.cpp of the BE process, it is mandatory to check
that the `ulimit` value must be greater than 60,000. When starting with
Docker or Docker-Compose, it is necessary to preemptively change the
corresponding value on the host machine. This change is very unfriendly
to Docker, as it loses its unique advantage of being able to "build
quickly and anywhere," and cannot become a fundamental capability for
rapid startup. Therefore, a new environment variable has been added to
control whether to skip this check value. The default value is false,
which enforces the check of this value. When set to true, it skips the
check and starts directly.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 16, 2024
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40296 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43d54fe30213336eb047b9fb8a3347e47485b7e9, data reload: false

------ Round 1 ----------------------------------
q1	17588	7352	7281	7281
q2	2036	166	178	166
q3	10733	1067	1206	1067
q4	10540	749	708	708
q5	7743	2774	2743	2743
q6	232	145	141	141
q7	942	603	601	601
q8	9578	1904	2000	1904
q9	7799	6343	6451	6343
q10	6994	2292	2306	2292
q11	462	253	259	253
q12	400	209	208	208
q13	17803	2980	2931	2931
q14	234	209	214	209
q15	556	518	514	514
q16	676	635	598	598
q17	956	553	540	540
q18	7206	6486	6420	6420
q19	1628	1046	962	962
q20	482	205	208	205
q21	3875	3225	3275	3225
q22	1042	985	985	985
Total cold run time: 109505 ms
Total hot run time: 40296 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7243	7176	7246	7176
q2	331	233	224	224
q3	2816	2894	2873	2873
q4	2004	1765	1781	1765
q5	5619	5693	5650	5650
q6	222	142	136	136
q7	2173	1765	1786	1765
q8	3304	3511	3474	3474
q9	8699	8907	8797	8797
q10	3523	3491	3496	3491
q11	580	501	487	487
q12	782	600	583	583
q13	16374	3126	3122	3122
q14	307	284	285	284
q15	556	530	518	518
q16	701	687	659	659
q17	1846	1615	1593	1593
q18	8172	8029	7430	7430
q19	8070	1621	1443	1443
q20	2057	1863	1823	1823
q21	5446	5335	5252	5252
q22	1134	1010	975	975
Total cold run time: 81959 ms
Total hot run time: 59520 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193311 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43d54fe30213336eb047b9fb8a3347e47485b7e9, data reload: false

query1	1248	939	922	922
query2	6252	2070	2054	2054
query3	10807	4221	4019	4019
query4	66338	29546	23577	23577
query5	5338	440	444	440
query6	461	187	183	183
query7	5690	318	322	318
query8	318	222	238	222
query9	9331	2672	2642	2642
query10	507	262	261	261
query11	17906	15252	15729	15252
query12	163	96	103	96
query13	1566	423	419	419
query14	11188	7292	6287	6287
query15	208	176	175	175
query16	7153	477	440	440
query17	1173	544	560	544
query18	1895	319	315	315
query19	215	152	161	152
query20	118	110	111	110
query21	60	42	48	42
query22	4755	4537	4278	4278
query23	35042	33823	33781	33781
query24	6020	2843	2929	2843
query25	519	391	383	383
query26	669	171	166	166
query27	1773	289	295	289
query28	4369	2501	2487	2487
query29	686	432	423	423
query30	254	161	177	161
query31	1016	821	811	811
query32	61	54	56	54
query33	478	268	276	268
query34	917	501	501	501
query35	857	750	739	739
query36	1101	963	966	963
query37	119	73	70	70
query38	4046	3981	3983	3981
query39	1529	1459	1468	1459
query40	133	83	79	79
query41	47	47	45	45
query42	110	95	91	91
query43	505	483	483	483
query44	1159	785	809	785
query45	187	166	173	166
query46	1172	739	711	711
query47	1976	1945	1885	1885
query48	472	360	372	360
query49	736	381	364	364
query50	836	415	421	415
query51	7265	7113	7249	7113
query52	94	90	81	81
query53	261	180	178	178
query54	550	453	438	438
query55	75	72	72	72
query56	255	232	224	224
query57	1186	1054	1087	1054
query58	223	208	210	208
query59	3077	3118	3303	3118
query60	282	259	260	259
query61	105	103	104	103
query62	786	669	684	669
query63	220	205	191	191
query64	1739	650	619	619
query65	3258	3150	3153	3150
query66	731	290	300	290
query67	15718	15622	15059	15059
query68	4500	557	540	540
query69	405	253	251	251
query70	1152	1114	1109	1109
query71	372	248	250	248
query72	6293	4046	2761	2761
query73	751	346	337	337
query74	9921	8869	8874	8869
query75	3301	2634	2583	2583
query76	2040	1053	1008	1008
query77	491	266	269	266
query78	10764	9902	9520	9520
query79	4695	592	601	592
query80	1893	447	440	440
query81	567	246	242	242
query82	771	126	117	117
query83	261	146	146	146
query84	292	91	91	91
query85	1592	362	362	362
query86	486	315	299	299
query87	4451	4244	4211	4211
query88	5410	2436	2385	2385
query89	431	302	285	285
query90	2047	190	186	186
query91	182	143	145	143
query92	61	48	47	47
query93	5656	543	539	539
query94	970	290	293	290
query95	348	250	248	248
query96	633	279	284	279
query97	3304	3141	3103	3103
query98	213	199	197	197
query99	1609	1280	1306	1280
Total cold run time: 331166 ms
Total hot run time: 193311 ms

@morningman morningman merged commit 33ccb0a into branch-3.0 Dec 23, 2024
20 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-45267-branch-3.0 branch December 23, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hello-stephen @doris-robot @morningman @dataroaring @FreeOnePlus