Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix](ShortCircuit) fix prepared statement with partial arguments prepared #45371 #45465

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45371

…pared (#45371)

We should record the placehold id map to both real Expr and the slot of
conjuncts.Otherwise the info is lost, and lead to the conjuncts updated
in wrong order(`updateScanNodeConjuncts`)
@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 16, 2024
@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40323 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc11d078320f974f171c085ea5467f3bbd9e2427, data reload: false

------ Round 1 ----------------------------------
q1	17589	7400	7264	7264
q2	2055	186	177	177
q3	10697	1672	1147	1147
q4	10564	752	696	696
q5	7754	2751	2715	2715
q6	232	145	144	144
q7	950	612	599	599
q8	9573	1908	1968	1908
q9	8000	6343	6386	6343
q10	6944	2288	2259	2259
q11	458	255	254	254
q12	391	213	206	206
q13	17772	2972	2934	2934
q14	256	212	202	202
q15	560	508	519	508
q16	664	593	605	593
q17	965	548	518	518
q18	7214	6486	6576	6486
q19	4348	1046	1028	1028
q20	469	202	193	193
q21	3886	3173	3241	3173
q22	1065	978	976	976
Total cold run time: 112406 ms
Total hot run time: 40323 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7409	7240	7197	7197
q2	320	238	240	238
q3	2991	2892	2893	2892
q4	2028	1692	1729	1692
q5	5689	5688	5693	5688
q6	228	142	153	142
q7	2170	1761	1715	1715
q8	3309	3465	3382	3382
q9	8915	8870	8742	8742
q10	3556	3499	3492	3492
q11	591	496	486	486
q12	822	617	614	614
q13	16458	3143	3134	3134
q14	303	275	275	275
q15	557	524	512	512
q16	690	666	651	651
q17	1841	1634	1589	1589
q18	8184	7745	7536	7536
q19	4655	1613	1595	1595
q20	2106	1833	1820	1820
q21	5332	5195	5392	5195
q22	1107	989	1005	989
Total cold run time: 79261 ms
Total hot run time: 59576 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194332 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc11d078320f974f171c085ea5467f3bbd9e2427, data reload: false

query1	1221	934	904	904
query2	6253	2033	1993	1993
query3	10835	4085	3933	3933
query4	67038	29244	23318	23318
query5	5766	435	447	435
query6	457	183	176	176
query7	5657	314	314	314
query8	322	226	228	226
query9	9565	2696	2657	2657
query10	525	261	259	259
query11	17951	15301	15638	15301
query12	153	98	98	98
query13	1539	413	417	413
query14	10717	6351	7332	6351
query15	218	172	175	172
query16	7367	542	533	533
query17	1364	591	567	567
query18	1959	322	309	309
query19	236	155	156	155
query20	119	113	123	113
query21	73	47	47	47
query22	4602	4714	4543	4543
query23	34290	33944	33975	33944
query24	6115	2965	2917	2917
query25	558	418	420	418
query26	691	170	168	168
query27	1840	301	298	298
query28	4428	2530	2500	2500
query29	686	466	453	453
query30	244	165	167	165
query31	991	821	863	821
query32	65	59	56	56
query33	489	294	287	287
query34	910	506	511	506
query35	838	753	776	753
query36	1081	971	955	955
query37	115	69	74	69
query38	4064	4058	3971	3971
query39	1520	1480	1446	1446
query40	143	81	77	77
query41	51	46	47	46
query42	112	97	97	97
query43	533	490	479	479
query44	1158	799	803	799
query45	178	171	175	171
query46	1187	716	728	716
query47	1976	1909	1904	1904
query48	465	367	367	367
query49	731	377	400	377
query50	823	434	418	418
query51	7299	7275	7001	7001
query52	99	89	88	88
query53	254	175	176	175
query54	547	438	437	437
query55	76	71	72	71
query56	242	240	249	240
query57	1180	1117	1104	1104
query58	222	196	215	196
query59	3043	2760	2813	2760
query60	291	250	240	240
query61	102	102	100	100
query62	770	631	676	631
query63	207	185	184	184
query64	1820	642	628	628
query65	3204	3126	3142	3126
query66	747	297	303	297
query67	15729	15434	15241	15241
query68	4551	548	552	548
query69	421	260	251	251
query70	1169	1115	1082	1082
query71	370	258	242	242
query72	6584	3903	3957	3903
query73	739	342	337	337
query74	10299	8875	9007	8875
query75	3322	2638	2571	2571
query76	2558	1069	977	977
query77	485	255	252	252
query78	10784	9725	9497	9497
query79	8026	587	606	587
query80	2050	426	418	418
query81	559	239	230	230
query82	1343	116	145	116
query83	259	141	139	139
query84	286	79	76	76
query85	1668	291	282	282
query86	458	294	278	278
query87	4545	4171	4191	4171
query88	5538	2384	2388	2384
query89	544	282	285	282
query90	2105	185	191	185
query91	178	173	139	139
query92	64	47	51	47
query93	6500	551	539	539
query94	878	297	289	289
query95	350	249	250	249
query96	623	275	276	275
query97	3304	3126	3146	3126
query98	213	205	194	194
query99	1629	1300	1277	1277
Total cold run time: 338453 ms
Total hot run time: 194332 ms

@eldenmoon eldenmoon merged commit 820b300 into branch-3.0 Dec 17, 2024
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-45371-branch-3.0 branch December 17, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants