[Enhancement] (nereids)implement showColumnStatsCommand in nereids #45439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
1 similar comment
|
run buildall |
| return new ShowColumnStatsCommand(new TableNameInfo(tableNameParts), colNames, partitionNames, isCached); | ||
| } | ||
|
|
||
| private PartitionNames parsePartitionSpec(PartitionSpecContext ctx) { |
There was a problem hiding this comment.
there is a visitPartitionSpec method already, please use it instead of creating a new one. Take bellow as example:
Pair<Boolean, List<String>> partitionSpec = visitPartitionSpec(ctx.partitions);
PartitionNamesInfo partitionNames = new PartitionNamesInfo(partitionSpec.first, partitionSpec.second);
|
|
||
| private final TableNameInfo tableName; | ||
| private final List<String> columnNames; | ||
| private final PartitionNames partitionNames; |
There was a problem hiding this comment.
Suggested change
| private final PartitionNames partitionNames; | |
| private final PartitionNamesInfo partitionNames; |
use PartitionNamesInfo instead
There was a problem hiding this comment.
done - pls review
| analyze(); | ||
| } | ||
|
|
||
| public void analyze() throws AnalysisException { |
There was a problem hiding this comment.
use PartitionNamesInfo, PartitionNames don't need to be changed
There was a problem hiding this comment.
done - please review
msridhar78
force-pushed
the
show_column_stats
branch
2 times, most recently
from
c52a5c5 to
9367eb9
Compare
|
run buildall |
TPC-H: Total hot run time: 39896 ms |
TPC-DS: Total hot run time: 189738 ms |
ClickBench: Total hot run time: 32.98 s |
msridhar78
force-pushed
the
show_column_stats
branch
from
9367eb9 to
c3e07ca
Compare
|
run buildall |
TPC-H: Total hot run time: 39693 ms |
TPC-DS: Total hot run time: 195779 ms |
ClickBench: Total hot run time: 33.17 s |
|
run buildall |
TPC-H: Total hot run time: 39966 ms |
TPC-DS: Total hot run time: 197126 ms |
ClickBench: Total hot run time: 32.12 s |
|
run buildall |
TPC-H: Total hot run time: 32508 ms |
TPC-DS: Total hot run time: 196811 ms |
ClickBench: Total hot run time: 31.28 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #42717
Related PR: #xxx
Problem Summary:
[Enhancement] (nereids)implement showColumnStatsCommand in nereids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)