Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](tvf) Tvf supports to parse the enclose character in csv files #45407

Merged
merged 3 commits into from
Dec 18, 2024
Merged

[fix](tvf) Tvf supports to parse the enclose character in csv files #45407

merged 3 commits into from
Dec 18, 2024
+114 −1

Conversation

BePPPower
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

Tvf supports to parse the enclose character in csv files

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BePPPower
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.76% (10109/26082)
Line Coverage: 29.69% (84846/285766)
Region Coverage: 28.76% (43563/151446)
Branch Coverage: 25.32% (22133/87414)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2ec488dd977635b39c09967e6122745c042cb18a_2ec488dd977635b39c09967e6122745c042cb18a/report/index.html

morningman
morningman previously approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.76% (10109/26082)
Line Coverage: 29.70% (84882/285787)
Region Coverage: 28.76% (43565/151459)
Branch Coverage: 25.32% (22133/87424)
Coverage Report: http://coverage.selectdb-in.cc/coverage/41bda7fe60b84e39915b39f471513d303887fc5e_41bda7fe60b84e39915b39f471513d303887fc5e/report/index.html

@BePPPower
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.82% (10125/26084)
Line Coverage: 29.76% (85078/285896)
Region Coverage: 28.81% (43646/151478)
Branch Coverage: 25.35% (22162/87432)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4819d16773098e4c41713977e0e541664150ce37_4819d16773098e4c41713977e0e541664150ce37/report/index.html

@BePPPower
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.86% (10128/26064)
Line Coverage: 29.77% (85122/285913)
Region Coverage: 28.83% (43673/151495)
Branch Coverage: 25.36% (22181/87454)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3f0baf0f874d147c01d31fba659309a464b516e8_3f0baf0f874d147c01d31fba659309a464b516e8/report/index.html

morningman
morningman approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 18, 2024
@morningman morningman merged commit fe42ec9 into apache:master Dec 18, 2024
23 of 26 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@BePPPower
[fix](tvf) Tvf supports to parse the enclose character in csv files (#…
53e7efa 
…45407)

### What problem does this PR solve?

Problem Summary:

Tvf supports to parse the enclose character in csv files
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
@BePPPower
[fix](tvf) Tvf supports to parse the enclose character in csv files (#…
e10128b 
…45407)

### What problem does this PR solve?

Problem Summary:

Tvf supports to parse the enclose character in csv files
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Dec 19, 2024
@github-actions @BePPPower
branch-2.1: [fix](tvf) Tvf supports to parse the enclose character in…
d6c629d 
… csv files #45407 (#45570)

Cherry-picked from #45407

Co-authored-by: Tiewei Fang <[email protected]>
morningman pushed a commit that referenced this pull request Dec 20, 2024
@github-actions @BePPPower
branch-3.0: [fix](tvf) Tvf supports to parse the enclose character in…
e76c612 
… csv files #45407 (#45568)

Cherry-picked from #45407

Co-authored-by: Tiewei Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubgeter hubgeter hubgeter approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BePPPower @hello-stephen @doris-robot @morningman @hubgeter @yiguolei @wm1581066