Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals #45335

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals #45335

merged 1 commit into from
Dec 12, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Dec 12, 2024

and remove useless logs

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@w41ter
Copy link
Contributor Author

w41ter commented Dec 12, 2024

run buildall

@w41ter w41ter mentioned this pull request Dec 12, 2024
Closed
16 tasks
@doris-robot
Copy link

TPC-H: Total hot run time: 39898 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bdd69701ed90bf308fc5558daa652f15ace67d33, data reload: false

------ Round 1 ----------------------------------
q1	17968	8141	7240	7240
q2	2045	179	163	163
q3	11031	1076	1186	1076
q4	10524	708	673	673
q5	7609	2696	2666	2666
q6	241	147	145	145
q7	977	627	599	599
q8	9241	1822	1877	1822
q9	6655	6450	6465	6450
q10	7046	2285	2353	2285
q11	466	248	257	248
q12	436	222	226	222
q13	17800	3009	2990	2990
q14	253	209	218	209
q15	586	522	522	522
q16	652	584	570	570
q17	993	599	661	599
q18	7276	6739	6644	6644
q19	1353	1001	1017	1001
q20	478	190	189	189
q21	4184	3315	3267	3267
q22	390	318	318	318
Total cold run time: 108204 ms
Total hot run time: 39898 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7325	7219	7225	7219
q2	337	232	225	225
q3	2905	2890	2942	2890
q4	2071	1829	1892	1829
q5	5649	5633	5681	5633
q6	228	147	140	140
q7	2248	1808	1819	1808
q8	3410	3551	3537	3537
q9	8841	9104	9025	9025
q10	3597	3547	3535	3535
q11	589	520	521	520
q12	841	640	613	613
q13	12009	3244	3184	3184
q14	305	274	285	274
q15	576	504	537	504
q16	689	642	628	628
q17	1860	1676	1569	1569
q18	8382	7948	7599	7599
q19	1783	1517	1557	1517
q20	2126	1855	1920	1855
q21	5740	5525	5511	5511
q22	623	581	615	581
Total cold run time: 72134 ms
Total hot run time: 60196 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197161 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bdd69701ed90bf308fc5558daa652f15ace67d33, data reload: false

query1	1249	967	959	959
query2	6278	2022	2073	2022
query3	10949	4563	4352	4352
query4	67190	29269	23406	23406
query5	4893	455	442	442
query6	405	174	165	165
query7	5629	298	299	298
query8	312	240	236	236
query9	9409	2747	2724	2724
query10	486	254	253	253
query11	17605	15255	15697	15255
query12	174	102	102	102
query13	1606	436	428	428
query14	10308	7646	7552	7552
query15	225	185	187	185
query16	7076	440	479	440
query17	1130	558	560	558
query18	1226	306	317	306
query19	201	151	150	150
query20	121	125	110	110
query21	206	104	104	104
query22	4604	4627	4505	4505
query23	34259	34453	34419	34419
query24	5430	2481	2448	2448
query25	515	420	410	410
query26	651	154	151	151
query27	1754	289	288	288
query28	4813	2477	2478	2477
query29	687	466	457	457
query30	215	154	159	154
query31	1036	856	835	835
query32	67	59	61	59
query33	451	309	323	309
query34	968	552	515	515
query35	901	791	764	764
query36	1095	989	988	988
query37	123	73	68	68
query38	4420	4473	4500	4473
query39	1480	1476	1435	1435
query40	203	97	98	97
query41	42	41	41	41
query42	114	99	98	98
query43	536	520	500	500
query44	1183	841	844	841
query45	195	169	196	169
query46	1188	724	717	717
query47	2048	1903	1931	1903
query48	413	325	330	325
query49	723	387	406	387
query50	810	394	389	389
query51	7398	7249	7095	7095
query52	96	88	90	88
query53	258	174	176	174
query54	505	388	395	388
query55	78	75	86	75
query56	243	234	222	222
query57	1255	1109	1098	1098
query58	216	200	210	200
query59	3347	3235	3006	3006
query60	266	242	247	242
query61	107	106	106	106
query62	792	654	682	654
query63	210	178	184	178
query64	1368	680	638	638
query65	3279	3195	3201	3195
query66	642	304	306	304
query67	15897	15467	15450	15450
query68	4265	576	567	567
query69	432	261	248	248
query70	1212	1092	1082	1082
query71	359	244	249	244
query72	6214	3981	4024	3981
query73	759	348	359	348
query74	10117	8986	8944	8944
query75	3381	2672	2659	2659
query76	1930	1047	1142	1047
query77	498	259	284	259
query78	10419	9424	9389	9389
query79	1094	585	588	585
query80	746	421	455	421
query81	508	233	227	227
query82	1314	120	126	120
query83	171	146	147	146
query84	286	76	70	70
query85	900	300	310	300
query86	336	292	311	292
query87	4630	4506	4529	4506
query88	3269	2251	2186	2186
query89	417	293	303	293
query90	2026	187	182	182
query91	130	101	101	101
query92	56	49	48	48
query93	1110	553	555	553
query94	754	289	297	289
query95	345	253	251	251
query96	616	276	289	276
query97	2850	2665	2641	2641
query98	220	202	200	200
query99	1692	1324	1331	1324
Total cold run time: 316615 ms
Total hot run time: 197161 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.04 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bdd69701ed90bf308fc5558daa652f15ace67d33, data reload: false

query1	0.03	0.03	0.04
query2	0.08	0.05	0.04
query3	0.24	0.05	0.06
query4	1.65	0.09	0.09
query5	0.41	0.38	0.40
query6	1.17	0.67	0.65
query7	0.02	0.02	0.02
query8	0.05	0.05	0.04
query9	0.55	0.50	0.51
query10	0.55	0.59	0.56
query11	0.16	0.11	0.12
query12	0.15	0.12	0.13
query13	0.61	0.60	0.60
query14	2.89	2.74	2.76
query15	0.93	0.84	0.83
query16	0.39	0.38	0.37
query17	1.04	1.05	1.07
query18	0.18	0.18	0.19
query19	1.84	1.83	1.93
query20	0.02	0.02	0.01
query21	15.39	0.66	0.67
query22	4.50	7.30	1.84
query23	18.26	1.37	1.31
query24	2.16	0.25	0.22
query25	0.15	0.08	0.09
query26	0.26	0.18	0.18
query27	0.08	0.08	0.08
query28	13.20	1.17	1.15
query29	12.69	3.33	3.29
query30	0.24	0.06	0.06
query31	2.88	0.40	0.39
query32	3.24	0.48	0.47
query33	3.14	3.03	3.07
query34	16.81	4.46	4.44
query35	4.51	4.55	4.57
query36	0.67	0.47	0.52
query37	0.19	0.17	0.16
query38	0.16	0.16	0.15
query39	0.05	0.04	0.04
query40	0.17	0.13	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 111.9 s
Total hot run time: 33.04 s

dataroaring
dataroaring approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 09619fc into apache:master Dec 12, 2024
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@w41ter
[fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals and remov…
bfe7a9e 
…e useless logs (#45335)
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
@w41ter
[fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals and remov…
278e2ee 
…e useless logs (#45335)
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Merged
@w41ter w41ter deleted the remove_useless_log branch December 12, 2024 13:01
dataroaring pushed a commit that referenced this pull request Dec 12, 2024
@github-actions @w41ter
branch-3.0: [fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals
ad2dcb4 
#45335 (#45363)

Cherry-picked from #45335

Co-authored-by: walter <[email protected]>
w41ter added a commit that referenced this pull request Dec 13, 2024
@github-actions @w41ter
branch-2.1: [fix](persist) Fix TableAddOrDropInvertedIndicesInfo.equals
4d6d9a6 
#45335 (#45364)

Cherry-picked from #45335

Co-authored-by: walter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@bobhan1 bobhan1 bobhan1 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@w41ter @doris-robot @bobhan1 @dataroaring @gavinchou