Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix] Add column with default value string throw exception #45000 #45315

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #45000

```
ALTER TABLE t ADD COLUMN create_time VARCHAR(20) DEFAULT "CURRENT_TIMESTAMP";
```
```
errCode = 2, detailMessage = Unexpected exception: Cannot invoke "org.apache.doris.analysis.DefaultValueExprDef.getExprName()" because "this.defaultValueExprDef" is null
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 11, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40394 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cd8a525e55ccdef815c7004a62948377187e33f, data reload: false

------ Round 1 ----------------------------------
q1	17606	7288	7324	7288
q2	2071	163	167	163
q3	10715	1061	1150	1061
q4	10541	736	821	736
q5	7741	2797	2806	2797
q6	236	147	147	147
q7	984	607	601	601
q8	9571	1893	1963	1893
q9	7808	6379	6376	6376
q10	6936	2272	2316	2272
q11	447	259	269	259
q12	389	209	207	207
q13	17786	2985	2961	2961
q14	230	213	201	201
q15	570	522	516	516
q16	656	602	603	602
q17	956	541	527	527
q18	7213	6486	6388	6388
q19	1844	1050	1025	1025
q20	489	217	200	200
q21	3848	3301	3211	3211
q22	1054	980	963	963
Total cold run time: 109691 ms
Total hot run time: 40394 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7359	7217	7266	7217
q2	329	228	234	228
q3	2893	2898	2899	2898
q4	1976	1748	1733	1733
q5	5615	5715	5731	5715
q6	230	141	146	141
q7	2211	1805	1805	1805
q8	3287	3518	3438	3438
q9	8824	8816	8790	8790
q10	3544	3529	3481	3481
q11	584	505	504	504
q12	800	631	627	627
q13	16559	3134	3136	3134
q14	314	273	274	273
q15	562	522	517	517
q16	717	668	668	668
q17	1841	1610	1602	1602
q18	8204	7750	7532	7532
q19	5009	1627	1559	1559
q20	2072	1886	1825	1825
q21	5500	5407	5369	5369
q22	1113	1036	1028	1028
Total cold run time: 79543 ms
Total hot run time: 60084 ms

@dataroaring dataroaring merged commit 2df7217 into branch-3.0 Dec 12, 2024
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-45000-branch-3.0 branch December 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants