Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](iceberg)Fill in the detailed error information #45285

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Dec 11, 2024

What problem does this PR solve?

Problem Summary:

When dropping a database, fill in the detailed error information.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wuwenchi
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40067 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ccd0d0d10c0ff154a8ea0eae6b8c982e71ddc4b, data reload: false

------ Round 1 ----------------------------------
q1	17574	7446	7256	7256
q2	2046	174	168	168
q3	10685	1098	1181	1098
q4	10563	740	721	721
q5	7620	2719	2696	2696
q6	245	154	151	151
q7	986	633	623	623
q8	9255	1849	1909	1849
q9	6592	6493	6426	6426
q10	7035	2283	2298	2283
q11	460	255	254	254
q12	435	222	225	222
q13	17790	3053	3082	3053
q14	242	210	205	205
q15	577	530	532	530
q16	657	587	592	587
q17	991	558	584	558
q18	7231	6691	6643	6643
q19	1342	1060	1033	1033
q20	475	182	180	180
q21	4041	3216	3374	3216
q22	374	315	315	315
Total cold run time: 107216 ms
Total hot run time: 40067 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7242	7307	7208	7208
q2	327	225	230	225
q3	2918	2793	2955	2793
q4	2093	1874	1817	1817
q5	5706	5690	5649	5649
q6	221	139	137	137
q7	2265	1781	1798	1781
q8	3364	3538	3513	3513
q9	8912	9106	9036	9036
q10	3573	3561	3549	3549
q11	621	522	514	514
q12	811	583	605	583
q13	12462	3214	3245	3214
q14	302	288	271	271
q15	581	522	529	522
q16	699	668	651	651
q17	1878	1619	1584	1584
q18	8288	7701	7586	7586
q19	1759	1577	1512	1512
q20	2106	1915	1879	1879
q21	5656	5456	5618	5456
q22	657	574	593	574
Total cold run time: 72441 ms
Total hot run time: 60054 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197693 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ccd0d0d10c0ff154a8ea0eae6b8c982e71ddc4b, data reload: false

query1	1249	1017	928	928
query2	6405	2062	2057	2057
query3	11106	4742	4553	4553
query4	32973	23418	23527	23418
query5	3489	479	451	451
query6	278	190	180	180
query7	3979	296	297	296
query8	311	245	239	239
query9	9405	2713	2714	2713
query10	472	247	258	247
query11	17822	15539	15185	15185
query12	160	113	103	103
query13	1573	446	419	419
query14	8915	7814	7641	7641
query15	301	207	202	202
query16	7953	494	470	470
query17	1837	607	591	591
query18	1973	327	320	320
query19	395	203	162	162
query20	122	118	116	116
query21	205	104	113	104
query22	4893	4630	4602	4602
query23	35002	34083	34081	34081
query24	10371	2610	2480	2480
query25	602	389	403	389
query26	1179	150	147	147
query27	2343	283	283	283
query28	7552	2445	2471	2445
query29	808	416	450	416
query30	234	152	156	152
query31	1036	847	831	831
query32	98	57	59	57
query33	777	291	302	291
query34	1148	521	513	513
query35	926	774	790	774
query36	1148	964	984	964
query37	145	77	74	74
query38	4483	4368	4410	4368
query39	1507	1467	1459	1459
query40	198	104	99	99
query41	45	45	49	45
query42	123	103	98	98
query43	547	508	513	508
query44	1251	837	839	837
query45	192	171	168	168
query46	1228	764	754	754
query47	2027	1902	1910	1902
query48	419	335	332	332
query49	946	394	377	377
query50	853	381	385	381
query51	7374	7138	7242	7138
query52	101	85	93	85
query53	268	192	187	187
query54	1253	422	419	419
query55	87	80	75	75
query56	251	262	241	241
query57	1242	1110	1106	1106
query58	215	218	203	203
query59	3140	2999	2953	2953
query60	272	251	244	244
query61	111	111	112	111
query62	873	674	684	674
query63	214	204	184	184
query64	3915	669	643	643
query65	3266	3234	3217	3217
query66	880	312	300	300
query67	15827	15617	15605	15605
query68	4535	542	593	542
query69	442	249	252	249
query70	1233	1168	1167	1167
query71	346	248	244	244
query72	6341	4100	4262	4100
query73	764	443	357	357
query74	10396	9103	9078	9078
query75	3402	2674	2614	2614
query76	2746	1080	1132	1080
query77	400	296	335	296
query78	10455	9387	9405	9387
query79	1493	580	605	580
query80	1234	418	439	418
query81	545	235	229	229
query82	926	118	127	118
query83	236	136	138	136
query84	228	73	67	67
query85	1438	319	310	310
query86	406	307	294	294
query87	4786	4485	4579	4485
query88	3240	2208	2189	2189
query89	437	300	287	287
query90	1957	191	185	185
query91	143	106	108	106
query92	59	53	56	53
query93	1811	525	523	523
query94	899	310	309	309
query95	350	247	259	247
query96	627	273	286	273
query97	2811	2641	2696	2641
query98	218	200	204	200
query99	1551	1322	1328	1322
Total cold run time: 298748 ms
Total hot run time: 197693 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9ccd0d0d10c0ff154a8ea0eae6b8c982e71ddc4b, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.10
query5	0.43	0.44	0.40
query6	1.18	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.53	0.49
query10	0.55	0.56	0.57
query11	0.14	0.10	0.11
query12	0.14	0.12	0.11
query13	0.62	0.60	0.61
query14	2.70	2.83	2.83
query15	0.92	0.84	0.83
query16	0.39	0.38	0.39
query17	1.07	1.08	1.05
query18	0.23	0.21	0.21
query19	1.88	1.77	2.00
query20	0.02	0.02	0.01
query21	15.36	0.59	0.61
query22	3.03	2.09	1.90
query23	16.94	0.86	0.84
query24	3.29	0.98	1.87
query25	0.28	0.11	0.08
query26	0.56	0.14	0.15
query27	0.04	0.04	0.05
query28	10.12	1.11	1.08
query29	12.57	3.21	3.19
query30	0.25	0.07	0.06
query31	2.86	0.39	0.38
query32	3.26	0.46	0.46
query33	3.00	3.04	3.05
query34	17.09	4.55	4.48
query35	4.48	4.54	4.51
query36	0.67	0.49	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.15 s
Total hot run time: 32.84 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 742e441 into apache:master Dec 12, 2024
32 of 34 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
### What problem does this PR solve?

Problem Summary:

When dropping a database, fill in the detailed error information.
github-actions bot pushed a commit that referenced this pull request Dec 12, 2024
### What problem does this PR solve?

Problem Summary:

When dropping a database, fill in the detailed error information.
morningman pushed a commit that referenced this pull request Dec 15, 2024
morningman pushed a commit that referenced this pull request Dec 15, 2024
### What problem does this PR solve?

Problem Summary:

When dropping a database, fill in the detailed error information.
morningman pushed a commit that referenced this pull request Dec 17, 2024
morningman pushed a commit that referenced this pull request Dec 20, 2024
### What problem does this PR solve?

Related PR: #45285

Problem Summary:
When dropping a database, fill in the detailed error information.
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
### What problem does this PR solve?

Related PR: #45285

Problem Summary:
When dropping a database, fill in the detailed error information.
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
### What problem does this PR solve?

Related PR: #45285

Problem Summary:
When dropping a database, fill in the detailed error information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants