Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](txn insert) txn insert show error url #45254

Merged
merged 1 commit into from
Dec 11, 2024
Merged

[fix](txn insert) txn insert show error url #45254

merged 1 commit into from
Dec 11, 2024

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Dec 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

mysql> begin;

mysql> insert into test values('a', 'a', 1);

mysql> commit;
ERROR 1105 (HY000): errCode = 2, detailMessage = [DATA_QUALITY_ERROR]too many filtered rows, url: http://172.21.16.12:9082/api/_load_error_log?file=__shard_110/error_log_insert_stmt_txn_insert_ef05df534f6b4ad7-8782cce460d85b4b_733cffdc9392473f_bd6b2ec40c621119

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Dec 10, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.80% (10106/26046)
Line Coverage: 29.69% (84716/285307)
Region Coverage: 28.77% (43496/151206)
Branch Coverage: 25.32% (22093/87264)
Coverage Report: http://coverage.selectdb-in.cc/coverage/797669e7a878bcdabf1ddc7605dd7b5e7dde66aa_797669e7a878bcdabf1ddc7605dd7b5e7dde66aa/report/index.html

zhannngchen
zhannngchen approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit 1ee8d40 into apache:master Dec 11, 2024
34 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@mymeiyi
[fix](txn insert) txn insert show error url (#45254)
33d1993 
```
mysql> begin;

mysql> insert into test values('a', 'a', 1);

mysql> commit;
ERROR 1105 (HY000): errCode = 2, detailMessage = [DATA_QUALITY_ERROR]too many filtered rows, url: http://172.21.16.12:9082/api/_load_error_log?file=__shard_110/error_log_insert_stmt_txn_insert_ef05df534f6b4ad7-8782cce460d85b4b_733cffdc9392473f_bd6b2ec40c621119
```
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@mymeiyi
[fix](txn insert) txn insert show error url (#45254)
cfa58a7 
```
mysql> begin;

mysql> insert into test values('a', 'a', 1);

mysql> commit;
ERROR 1105 (HY000): errCode = 2, detailMessage = [DATA_QUALITY_ERROR]too many filtered rows, url: http://172.21.16.12:9082/api/_load_error_log?file=__shard_110/error_log_insert_stmt_txn_insert_ef05df534f6b4ad7-8782cce460d85b4b_733cffdc9392473f_bd6b2ec40c621119
```
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Closed
dataroaring pushed a commit that referenced this pull request Dec 12, 2024
@github-actions @mymeiyi
branch-3.0: [fix](txn insert) txn insert show error url #45254 (#45317)
6bfe8ec 
Cherry-picked from #45254

Co-authored-by: meiyi <[email protected]>
@mymeiyi mymeiyi mentioned this pull request Dec 13, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 13, 2024
@mymeiyi
branch-2.1: [fix](txn insert) txn insert show error url #45254 (#45381)
6dabdd6 
Cherry-picked from #45254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

@liaoxin01 liaoxin01 liaoxin01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mymeiyi @doris-robot @liaoxin01 @zhannngchen @dataroaring