-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Export) Cancel the export job when the ring buffer have no enough slot #45244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
16 tasks
morningman
changed the title
[fix](Export) Cacel the export job when the ring buffer have no enough slot
[fix](Export) Cancel the export job when the ring buffer have no enough slot
Dec 11, 2024
morningman
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Dec 11, 2024
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run buildall |
CalvinKirs
approved these changes
Dec 13, 2024
wuwenchi
approved these changes
Dec 13, 2024
Jibing-Li
approved these changes
Dec 13, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
…gh slot (#45244) Problem Summary: If there happen exceptions in `addMemoryTask`, we must update the state of the export job to `CANCELLED` because we have added this export job in `ExportMgr`.
dataroaring
pushed a commit
that referenced
this pull request
Dec 17, 2024
…have no enough slot #45244 (#45430) Cherry-picked from #45244 Co-authored-by: Tiewei Fang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.8-merged
dev/3.0.4-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Summary:
If there happen exceptions in
addMemoryTask
, we must update the state of the export job toCANCELLED
because we have added this export job inExportMgr
.Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)