Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Export) Cancel the export job when the ring buffer have no enough slot #45244

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

BePPPower
Copy link
Contributor

Problem Summary:

If there happen exceptions in addMemoryTask, we must update the state of the export job to CANCELLED because we have added this export job in ExportMgr.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman morningman changed the title [fix](Export) Cacel the export job when the ring buffer have no enough slot [fix](Export) Cancel the export job when the ring buffer have no enough slot Dec 11, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor

run buildall

@morningman morningman merged commit 12dcb17 into apache:master Dec 15, 2024
35 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 15, 2024
…gh slot (#45244)

Problem Summary:

If there happen exceptions in `addMemoryTask`, we must update the state
of the export job to `CANCELLED` because we have added this export job
in `ExportMgr`.
dataroaring pushed a commit that referenced this pull request Dec 17, 2024
…have no enough slot #45244 (#45430)

Cherry-picked from #45244

Co-authored-by: Tiewei Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants