-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) fix fe fold constant with date time out of range #45237
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40205 ms
|
TPC-DS: Total hot run time: 197339 ms
|
ClickBench: Total hot run time: 32.5 s
|
? new NullLiteral(DateTimeType.INSTANCE) | ||
: new DateTimeLiteral(dateTime.getYear(), dateTime.getMonthValue(), dateTime.getDayOfMonth(), | ||
if (isDateOutOfRange(dateTime)) { | ||
throw new NotSupportedException("date out of range"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should print the detail message for user to debug
3c4b7cd
to
848477d
Compare
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 32426 ms
|
TPC-DS: Total hot run time: 190717 ms
|
ClickBench: Total hot run time: 31.55 s
|
32648e5
to
1dbdfef
Compare
run buildall |
TPC-H: Total hot run time: 32789 ms
|
TPC-DS: Total hot run time: 196450 ms
|
ClickBench: Total hot run time: 31.77 s
|
This reverts commit 1dbdfef.
run buildall |
TPC-H: Total hot run time: 32530 ms
|
TPC-DS: Total hot run time: 191352 ms
|
ClickBench: Total hot run time: 31.39 s
|
run buildall |
TPC-H: Total hot run time: 32178 ms
|
TPC-DS: Total hot run time: 196652 ms
|
ClickBench: Total hot run time: 31.4 s
|
run buildall |
TPC-H: Total hot run time: 32313 ms
|
TPC-DS: Total hot run time: 191269 ms
|
ClickBench: Total hot run time: 30.85 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
return null 才是正确的返回方式 |
可能恰恰相反啊。。有些return null的,我们反而要逐渐改到报错去 |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When running sql:
select date_add('9999-12-31 23:59:59', interval 5 second);
it should throw exception but not return null value
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)