Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](ip)fix default value for ip #45194

Merged
merged 4 commits into from
Dec 13, 2024
Merged

[fix](ip)fix default value for ip #45194

merged 4 commits into from
Dec 13, 2024

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Dec 9, 2024

What problem does this PR solve?

before this pr: we do not support create table for IP type with default value
like this:

mysql> CREATE TABLE table2
    -> (
    ->     col0 BIGINT  NOT NULL DEFAULT '1' ,
    ->     col24 IPV4  NULL DEFAULT '127.0.0.1'
    -> )
    -> DUPLICATE KEY(col0)
    -> DISTRIBUTED BY HASH(col0) BUCKETS 4
    -> PROPERTIES (
    ->     "replication_num" = "1"
    -> );
ERROR 1105 (HY000): errCode = 2, detailMessage = Unsupported type: ipv4

after this pr we deal with this problem
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

amorynan commented Dec 9, 2024

run buildall

morrySnow
morrySnow previously approved these changes Dec 10, 2024
View reviewed changes
@morrySnow morrySnow self-requested a review December 10, 2024 09:52
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 11, 2024
@amorynan
Copy link
Contributor Author

run buildall

yiguolei
yiguolei previously approved these changes Dec 12, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@amorynan
Copy link
Contributor Author

run buildall

@amorynan
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
eldenmoon
eldenmoon approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@eldenmoon eldenmoon merged commit 6cead2f into apache:master Dec 13, 2024
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@amorynan
[fix](ip)fix default value for ip (#45194)
47c9c4b 
before this pr: we do not support create table for IP type with default
value
like this:
```
mysql> CREATE TABLE table2
    -> (
    ->     col0 BIGINT  NOT NULL DEFAULT '1' ,
    ->     col24 IPV4  NULL DEFAULT '127.0.0.1'
    -> )
    -> DUPLICATE KEY(col0)
    -> DISTRIBUTED BY HASH(col0) BUCKETS 4
    -> PROPERTIES (
    ->     "replication_num" = "1"
    -> );
ERROR 1105 (HY000): errCode = 2, detailMessage = Unsupported type: ipv4
```
after this pr we deal with this problem
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@amorynan
[fix](ip)fix default value for ip (#45194)
861afbb 
before this pr: we do not support create table for IP type with default
value
like this:
```
mysql> CREATE TABLE table2
    -> (
    ->     col0 BIGINT  NOT NULL DEFAULT '1' ,
    ->     col24 IPV4  NULL DEFAULT '127.0.0.1'
    -> )
    -> DUPLICATE KEY(col0)
    -> DISTRIBUTED BY HASH(col0) BUCKETS 4
    -> PROPERTIES (
    ->     "replication_num" = "1"
    -> );
ERROR 1105 (HY000): errCode = 2, detailMessage = Unsupported type: ipv4
```
after this pr we deal with this problem
@github-actions github-actions bot mentioned this pull request Dec 13, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 16, 2024
@github-actions @amorynan
branch-3.0: [fix](ip)fix default value for ip #45194 (#45391)
11b8b95 
Cherry-picked from #45194

Co-authored-by: amory <[email protected]>
yiguolei pushed a commit that referenced this pull request Dec 16, 2024
@github-actions @amorynan
branch-2.1: [fix](ip)fix default value for ip #45194 (#45392)
4df7069 
Cherry-picked from #45194

Co-authored-by: amory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

@yiguolei yiguolei yiguolei left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amorynan @doris-robot @yiguolei @eldenmoon @morrySnow @dataroaring