Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [fix](move-memtable) tolerate non-open streams in close wait #44680 #45154

Merged
merged 1 commit into from
Dec 8, 2024
Merged

branch-2.1: [fix](move-memtable) tolerate non-open streams in close wait #44680 #45154

merged 1 commit into from
Dec 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2024

Cherry-picked from #44680

@kaijchen
[fix](move-memtable) tolerate non-open streams in close wait (#44680)
c2b3c2a 
Related PR: #44344
`VTabletWriterV2::_select_streams()` is already checking if there is
enough downstream BE to meet the replication requirements.
`VTabletWriterV2::close()` should tolerate those non-open streams on
close wait.

Debug point `VTabletWriterV2._open_streams.skip_two_backends` is added
along with `VTabletWriterV2._open_streams.skip_one_backend` to check
this behavior.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 7, 2024
@dataroaring dataroaring reopened this Dec 7, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.46% (9542/26174)
Line Coverage: 27.91% (78458/281152)
Region Coverage: 26.56% (40232/151491)
Branch Coverage: 23.35% (20424/87466)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c2b3c2a715ddc12f546b49517d2e35d717f971e5_c2b3c2a715ddc12f546b49517d2e35d717f971e5/report/index.html

@yiguolei yiguolei merged commit cf2e211 into branch-2.1 Dec 8, 2024
17 of 19 checks passed
@github-actions github-actions bot deleted the auto-pick-44680-branch-2.1 branch December 8, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doris-robot @yiguolei @dataroaring @kaijchen