[test](index compaction)Add index compaction exception fault injection cases #45127

qidaye · 2024-12-06T11:10:27Z

What problem does this PR solve?

Problem Summary:

Add skip index compaction logic when index compaction encounters exceptions
Optimize fault injection regression cases

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

…n cases 1. Add skip index compaction logic when index compaction encounters exceptions 2. Optimize fault injection regression cases

doris-robot · 2024-12-06T11:10:33Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

qidaye · 2024-12-06T11:11:48Z

run buildall

doris-robot · 2024-12-06T12:38:38Z

TPC-H: Total hot run time: 40303 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0d08ead1b4e3daae2a012e59955da0e6c47bc307, data reload: false

------ Round 1 ----------------------------------
q1	17683	7508	7332	7332
q2	2075	181	185	181
q3	10634	1165	1235	1165
q4	10387	742	791	742
q5	7599	3115	2704	2704
q6	233	150	154	150
q7	1030	622	613	613
q8	9271	1846	1897	1846
q9	6689	6479	6499	6479
q10	6957	2296	2327	2296
q11	454	264	265	264
q12	421	225	223	223
q13	17801	3047	3071	3047
q14	236	219	218	218
q15	546	540	522	522
q16	630	592	588	588
q17	981	654	561	561
q18	7687	6786	6723	6723
q19	1337	1028	1004	1004
q20	464	196	181	181
q21	4006	3397	3140	3140
q22	396	324	331	324
Total cold run time: 107517 ms
Total hot run time: 40303 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7254	7231	7242	7231
q2	332	232	233	232
q3	2911	3008	3095	3008
q4	2096	1833	1812	1812
q5	5614	5746	5676	5676
q6	223	140	141	140
q7	2213	1772	1806	1772
q8	3458	3543	3542	3542
q9	9083	9055	9013	9013
q10	3592	3527	3558	3527
q11	611	507	502	502
q12	822	619	607	607
q13	12591	3222	3189	3189
q14	328	282	272	272
q15	585	528	553	528
q16	674	650	637	637
q17	1784	1627	1574	1574
q18	7827	7497	7508	7497
q19	1674	1443	1569	1443
q20	2046	1905	1798	1798
q21	5390	5341	5378	5341
q22	646	542	598	542
Total cold run time: 71754 ms
Total hot run time: 59883 ms

doris-robot · 2024-12-06T12:50:42Z

TPC-DS: Total hot run time: 190960 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0d08ead1b4e3daae2a012e59955da0e6c47bc307, data reload: false

query1	1165	384	378	378
query2	6516	2077	2049	2049
query3	6712	221	210	210
query4	33847	23498	23551	23498
query5	4387	468	448	448
query6	296	197	191	191
query7	4625	304	311	304
query8	298	237	242	237
query9	9489	2751	2746	2746
query10	488	263	264	263
query11	17967	15152	15302	15152
query12	146	99	102	99
query13	1638	413	424	413
query14	9326	6871	6498	6498
query15	230	179	181	179
query16	7796	456	488	456
query17	1590	565	542	542
query18	2006	284	288	284
query19	218	158	143	143
query20	115	110	108	108
query21	209	100	104	100
query22	4514	4391	4300	4300
query23	34820	34215	35753	34215
query24	11680	2407	2429	2407
query25	531	381	379	379
query26	1106	153	157	153
query27	2987	275	274	274
query28	8019	2445	2476	2445
query29	641	411	402	402
query30	303	151	157	151
query31	1025	809	850	809
query32	95	58	56	56
query33	764	305	292	292
query34	976	537	518	518
query35	887	749	772	749
query36	1100	946	977	946
query37	199	78	79	78
query38	4376	4255	4180	4180
query39	1492	1441	1409	1409
query40	284	107	106	106
query41	51	47	48	47
query42	110	98	102	98
query43	528	495	486	486
query44	1257	810	788	788
query45	187	169	175	169
query46	1155	732	728	728
query47	1957	1871	1828	1828
query48	437	319	312	312
query49	1267	419	374	374
query50	818	369	397	369
query51	7407	7159	7141	7141
query52	105	91	91	91
query53	254	189	181	181
query54	1043	399	396	396
query55	76	82	80	80
query56	256	224	250	224
query57	1249	1136	1133	1133
query58	265	206	215	206
query59	3283	3234	3148	3148
query60	274	246	242	242
query61	109	106	106	106
query62	896	652	663	652
query63	204	184	180	180
query64	5086	678	642	642
query65	3260	3238	3287	3238
query66	1286	324	312	312
query67	16103	15982	15689	15689
query68	4934	558	547	547
query69	428	256	255	255
query70	1195	1200	1126	1126
query71	345	244	250	244
query72	5991	3819	4111	3819
query73	770	373	372	372
query74	10359	9017	9053	9017
query75	3416	2647	2690	2647
query76	2899	1069	1122	1069
query77	394	313	267	267
query78	10424	9490	9466	9466
query79	1886	606	609	606
query80	1191	438	416	416
query81	537	255	238	238
query82	904	130	119	119
query83	240	146	157	146
query84	233	70	67	67
query85	1385	303	311	303
query86	462	301	306	301
query87	4660	4604	4521	4521
query88	3732	2240	2199	2199
query89	414	298	309	298
query90	2174	192	190	190
query91	134	106	112	106
query92	65	51	52	51
query93	1616	552	541	541
query94	1062	298	300	298
query95	366	253	246	246
query96	624	280	282	280
query97	2821	2667	2718	2667
query98	257	196	196	196
query99	1542	1336	1315	1315
Total cold run time: 301246 ms
Total hot run time: 190960 ms

doris-robot · 2024-12-06T12:56:11Z

ClickBench: Total hot run time: 33.13 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0d08ead1b4e3daae2a012e59955da0e6c47bc307, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.08	0.06
query4	1.62	0.10	0.11
query5	0.41	0.42	0.42
query6	1.18	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.53	0.50
query10	0.55	0.57	0.55
query11	0.14	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.61	0.60
query14	2.78	2.72	2.71
query15	0.89	0.83	0.83
query16	0.36	0.37	0.39
query17	0.98	1.03	1.03
query18	0.22	0.23	0.22
query19	1.95	1.81	1.93
query20	0.01	0.01	0.02
query21	15.36	0.60	0.60
query22	2.38	1.94	2.84
query23	16.83	0.97	0.92
query24	3.18	1.26	1.47
query25	0.19	0.12	0.10
query26	0.53	0.13	0.14
query27	0.04	0.05	0.06
query28	10.03	1.11	1.09
query29	12.58	3.26	3.21
query30	0.25	0.06	0.07
query31	2.87	0.38	0.37
query32	3.27	0.47	0.48
query33	3.02	3.05	3.10
query34	17.00	4.46	4.50
query35	4.50	4.47	4.44
query36	0.69	0.50	0.48
query37	0.10	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.03 s
Total hot run time: 33.13 s

doris-robot · 2024-12-09T04:12:35Z

TeamCity be ut coverage result:
Function Coverage: 38.47% (10006/26010)
Line Coverage: 29.49% (83933/284593)
Region Coverage: 28.59% (43124/150834)
Branch Coverage: 25.18% (21916/87038)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0d08ead1b4e3daae2a012e59955da0e6c47bc307_0d08ead1b4e3daae2a012e59955da0e6c47bc307/report/index.html

zzzxl1993

LGTM

github-actions · 2024-12-09T08:52:31Z

PR approved by anyone and no changes requested.

be/src/olap/compaction.cpp

qidaye · 2024-12-11T12:15:17Z

run buildall

github-actions

clang-tidy made some suggestions

be/src/olap/compaction.cpp

doris-robot · 2024-12-11T12:35:14Z

TPC-H: Total hot run time: 39757 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a2809702274224954d998a641642e5cc456d0df9, data reload: false

------ Round 1 ----------------------------------
q1	17626	7429	7208	7208
q2	2045	177	175	175
q3	10541	1135	1182	1135
q4	10229	713	731	713
q5	7605	2711	2689	2689
q6	236	144	151	144
q7	986	618	627	618
q8	9245	1874	1921	1874
q9	6606	6432	6431	6431
q10	6931	2294	2345	2294
q11	460	251	255	251
q12	409	220	224	220
q13	17777	3008	2990	2990
q14	228	217	212	212
q15	571	509	512	509
q16	651	594	581	581
q17	957	486	543	486
q18	7428	6638	6771	6638
q19	1346	991	949	949
q20	482	184	188	184
q21	4013	3146	3238	3146
q22	384	310	320	310
Total cold run time: 106756 ms
Total hot run time: 39757 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7170	7186	7217	7186
q2	340	229	231	229
q3	2952	2803	2967	2803
q4	2125	1855	1845	1845
q5	5624	5690	5630	5630
q6	221	146	141	141
q7	2271	1812	1777	1777
q8	3356	3552	3518	3518
q9	8915	8903	8921	8903
q10	3564	3520	3526	3520
q11	593	495	495	495
q12	793	642	608	608
q13	12406	3220	3135	3135
q14	307	261	270	261
q15	581	531	514	514
q16	677	625	632	625
q17	1785	1581	1533	1533
q18	7880	7519	7368	7368
q19	1660	1553	1480	1480
q20	2037	1807	1877	1807
q21	5371	5144	5219	5144
q22	608	568	574	568
Total cold run time: 71236 ms
Total hot run time: 59090 ms

doris-robot · 2024-12-11T12:47:18Z

TPC-DS: Total hot run time: 190488 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a2809702274224954d998a641642e5cc456d0df9, data reload: false

query1	982	364	379	364
query2	6510	2218	2036	2036
query3	6703	219	210	210
query4	33916	23349	23359	23349
query5	4337	449	448	448
query6	282	198	183	183
query7	4622	309	302	302
query8	307	234	225	225
query9	9670	2744	2726	2726
query10	479	245	253	245
query11	18020	15172	15071	15071
query12	163	100	103	100
query13	1687	425	430	425
query14	9387	7660	6975	6975
query15	298	184	187	184
query16	8209	475	405	405
query17	1773	580	570	570
query18	2147	306	315	306
query19	369	157	140	140
query20	117	108	109	108
query21	204	101	98	98
query22	4564	4465	4388	4388
query23	34464	33704	33659	33659
query24	11488	2390	2522	2390
query25	674	377	381	377
query26	1862	156	150	150
query27	2858	281	275	275
query28	8163	2473	2446	2446
query29	1046	402	409	402
query30	301	150	149	149
query31	1029	804	814	804
query32	96	57	64	57
query33	765	306	282	282
query34	1036	516	518	516
query35	904	753	720	720
query36	1081	923	941	923
query37	285	83	71	71
query38	4335	4129	4216	4129
query39	1440	1392	1397	1392
query40	279	99	97	97
query41	51	43	45	43
query42	108	94	97	94
query43	546	496	508	496
query44	1256	826	822	822
query45	186	170	165	165
query46	1163	705	696	696
query47	1987	1864	1876	1864
query48	407	317	313	313
query49	1282	395	389	389
query50	785	378	378	378
query51	7280	7110	7137	7110
query52	102	94	88	88
query53	254	180	179	179
query54	1316	401	405	401
query55	86	88	75	75
query56	259	254	228	228
query57	1235	1092	1100	1092
query58	224	209	210	209
query59	3398	3304	3201	3201
query60	279	251	252	251
query61	114	110	140	110
query62	897	666	638	638
query63	215	192	187	187
query64	5061	667	633	633
query65	3262	3174	3226	3174
query66	1445	344	329	329
query67	16038	15757	15535	15535
query68	5326	584	574	574
query69	413	250	251	250
query70	1195	1136	1148	1136
query71	338	248	266	248
query72	6389	4066	4061	4061
query73	764	368	366	366
query74	10314	8824	8941	8824
query75	3428	2632	2666	2632
query76	3202	1167	1073	1073
query77	506	279	277	277
query78	10352	9549	9493	9493
query79	1510	595	633	595
query80	1096	427	443	427
query81	521	232	228	228
query82	917	114	123	114
query83	238	146	139	139
query84	231	68	73	68
query85	1339	317	315	315
query86	389	308	304	304
query87	4631	4582	4610	4582
query88	3230	2255	2223	2223
query89	421	301	305	301
query90	2024	188	187	187
query91	139	111	107	107
query92	59	51	52	51
query93	1097	541	559	541
query94	1124	286	281	281
query95	359	247	249	247
query96	617	288	279	279
query97	2862	2670	2682	2670
query98	216	195	196	195
query99	1515	1332	1303	1303
Total cold run time: 302850 ms
Total hot run time: 190488 ms

doris-robot · 2024-12-11T12:51:59Z

TeamCity be ut coverage result:
Function Coverage: 38.75% (10103/26074)
Line Coverage: 29.68% (84778/285612)
Region Coverage: 28.74% (43505/151361)
Branch Coverage: 25.30% (22099/87350)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a2809702274224954d998a641642e5cc456d0df9_a2809702274224954d998a641642e5cc456d0df9/report/index.html

doris-robot · 2024-12-11T12:52:47Z

ClickBench: Total hot run time: 33.72 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a2809702274224954d998a641642e5cc456d0df9, data reload: false

query1	0.04	0.05	0.03
query2	0.06	0.03	0.03
query3	0.23	0.08	0.06
query4	1.61	0.10	0.11
query5	0.43	0.40	0.42
query6	1.17	0.66	0.64
query7	0.03	0.02	0.02
query8	0.05	0.03	0.04
query9	0.58	0.51	0.50
query10	0.55	0.59	0.55
query11	0.15	0.11	0.11
query12	0.14	0.10	0.11
query13	0.60	0.60	0.60
query14	2.71	2.80	2.84
query15	0.91	0.82	0.82
query16	0.37	0.40	0.40
query17	1.07	1.11	1.00
query18	0.23	0.21	0.21
query19	2.00	1.88	2.04
query20	0.02	0.01	0.01
query21	15.36	0.58	0.57
query22	2.36	1.94	2.01
query23	17.02	0.98	0.71
query24	2.92	1.97	2.19
query25	0.29	0.13	0.20
query26	0.51	0.15	0.14
query27	0.07	0.04	0.04
query28	9.32	1.09	1.07
query29	12.53	3.32	3.28
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.28	0.45	0.45
query33	2.95	2.96	3.06
query34	17.14	4.45	4.46
query35	4.48	4.48	4.48
query36	0.68	0.49	0.51
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.46 s
Total hot run time: 33.72 s

csun5285

LGTM

airborne12

LGTM

github-actions · 2024-12-13T05:25:22Z

PR approved by at least one committer and no changes requested.

…n cases (#45127) Problem Summary: 1. Add skip index compaction logic when index compaction encounters exceptions 2. Optimize fault injection regression cases

…ult injection cases #45127 (#45396) Cherry-picked from #45127 Co-authored-by: qiye <[email protected]>

… case (#45784) Problem Summary: Related PR:#45127 When set `enable_match_without_inverted_index` to `false`, `enable_common_expr_pushdown` must be `true`, if not, it will throw `[E-6001]match_any not support execute_match` error.

[test](index compaction)Add index compaction exception fault injectio…

0d08ead

…n cases 1. Add skip index compaction logic when index compaction encounters exceptions 2. Optimize fault injection regression cases

zzzxl1993 approved these changes Dec 9, 2024

View reviewed changes

github-actions bot added the reviewed label Dec 9, 2024

csun5285 reviewed Dec 11, 2024

View reviewed changes

be/src/olap/compaction.cpp Show resolved Hide resolved

fix comment

a280970

github-actions bot reviewed Dec 11, 2024

View reviewed changes

be/src/olap/compaction.cpp Show resolved Hide resolved

csun5285 approved these changes Dec 12, 2024

View reviewed changes

airborne12 approved these changes Dec 13, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 13, 2024

airborne12 merged commit 7e478ca into apache:master Dec 13, 2024
26 of 28 checks passed

qidaye deleted the index_compaction_regression_exception_test branch December 13, 2024 06:13

qidaye added the dev/3.0.x label Dec 13, 2024

github-actions bot mentioned this pull request Dec 13, 2024

branch-3.0: [test](index compaction)Add index compaction exception fault injection cases #45127 #45396

Merged

qidaye added a commit that referenced this pull request Dec 13, 2024

branch-3.0: [test](index compaction)Add index compaction exception fa…

122d574

…ult injection cases #45127 (#45396) Cherry-picked from #45127 Co-authored-by: qiye <[email protected]>

qidaye added dev/3.0.4-merged and removed dev/3.0.x labels Dec 13, 2024

qidaye mentioned this pull request Dec 23, 2024

[test](index compaction)Fix unstable index compaction fault injection case #45784

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test](index compaction)Add index compaction exception fault injection cases #45127

[test](index compaction)Add index compaction exception fault injection cases #45127

qidaye commented Dec 6, 2024

doris-robot commented Dec 6, 2024

qidaye commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 9, 2024

zzzxl1993 left a comment

github-actions bot commented Dec 9, 2024

qidaye commented Dec 11, 2024

github-actions bot left a comment

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

csun5285 left a comment

airborne12 left a comment

github-actions bot commented Dec 13, 2024

[test](index compaction)Add index compaction exception fault injection cases #45127

[test](index compaction)Add index compaction exception fault injection cases #45127

Conversation

qidaye commented Dec 6, 2024

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

doris-robot commented Dec 6, 2024

qidaye commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 6, 2024

doris-robot commented Dec 9, 2024

zzzxl1993 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024

qidaye commented Dec 11, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

doris-robot commented Dec 11, 2024

csun5285 left a comment

Choose a reason for hiding this comment

airborne12 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2024