-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](mtmv)Paimon queries the data in the cache instead of querying the latest data #44911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40539 ms
|
TPC-DS: Total hot run time: 191071 ms
|
ClickBench: Total hot run time: 33.3 s
|
morrySnow
reviewed
Dec 5, 2024
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonMetadataCacheMgr.java
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/source/PaimonSource.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneFileScanPartition.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneFileScanPartition.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/StatementContext.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonUtil.java
Show resolved
Hide resolved
run buildall |
TPC-H: Total hot run time: 39991 ms
|
TPC-DS: Total hot run time: 198051 ms
|
ClickBench: Total hot run time: 32.72 s
|
morrySnow
previously approved these changes
Dec 5, 2024
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Dec 5, 2024
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 32.62 s
|
run buildall |
TPC-H: Total hot run time: 40026 ms
|
TPC-DS: Total hot run time: 197014 ms
|
ClickBench: Total hot run time: 33.2 s
|
run p0 |
morningman
approved these changes
Dec 11, 2024
github-actions
bot
added
the
approved
Indicates a PR has been approved by one committer.
label
Dec 11, 2024
PR approved by at least one committer and no changes requested. |
16 tasks
morrySnow
pushed a commit
that referenced
this pull request
Dec 11, 2024
In the previous PR, a snapshot of the table was obtained and stored in the statementContext at the beginning of the query. The modification of this PR is to ensure that the same metadata is used during the query process. When calling the relevant interface, snapshot needs to be obtained from statementContext as a parameter and passed to the relevant method Related PR: #44911 #44673
zddr
added a commit
to zddr/incubator-doris
that referenced
this pull request
Dec 19, 2024
…the latest data (apache#44911) Problem Summary: - add `PaimonMetadataCacheMgr` in `ExternalMetaCacheMgr` to manage snapshotCache of paimon table - move paimonSchemaCache to PaimonMetadataCacheMgr, and add schemaId as part of key - PaimonExternalTable overrides the methods in ExternalTable and supports partition pruning - PaimonExternalTable implements the MvcTable interface, supporting the retrieval of snapshot data from the cache during queries to avoid cache refreshes that may result in different versions of metadata being used in a single query - MTMVTask retrieves snapshot data of mvccTable before the task starts to avoid cache refresh that may result in different versions of metadata being used in a single refresh task Paimon queries the data in the cache instead of querying the latest data behavior changes of query paimon table: - FE has just started and is query the latest data - Paimon data has changed, Doris is still query the previous data - After the snapshot cache expires, Doris will query the latest data - desc paimon; The schema corresponding to the snapshotId in the snapshot cache is displayed
morrySnow
pushed a commit
that referenced
this pull request
Dec 24, 2024
zddr
added a commit
to zddr/incubator-doris
that referenced
this pull request
Dec 24, 2024
…43959 apache#44911 (apache#45660) pick: apache#44911 apache#43959 only pick code about paimon, not pick some code about MTMV REFRESH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.8-merged
dev/3.0.4-merged
kind/behavior-changed
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PaimonMetadataCacheMgr
inExternalMetaCacheMgr
to manage snapshotCache of paimon tablebehavior changes of query paimon table:
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Paimon queries the data in the cache instead of querying the latest data
Release note
Paimon queries the data in the cache instead of querying the latest data
Check List (For Author)
Test
The previous case was able to cover normal read and write operations, but querying fixed versions of cases requires the ability to manipulate Paimon data, which is currently not possible
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)