-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](nerieds) date_format, to_monday, last_day, to_date, year implement Monotonic #44789
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 40062 ms
|
TPC-DS: Total hot run time: 196683 ms
|
ClickBench: Total hot run time: 33.11 s
|
Set<String> monoFormat = ImmutableSet.of("yyyyMMdd", "yyyy-MM-dd", "yyyy-MM-dd HH:mm:ss", "%Y", "%Y-%m", | ||
"%Y-%m-%d", "%Y-%m-%d %H", "%Y-%m-%d %H:%i", "%Y-%m-%d %H:%i:%s", "%Y-%m-%d %H:%i:%S", "%Y-%m-%d %T", | ||
"%Y%m%d", "%Y%m"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should ignore any blank in format
4f5a5fc
to
62b72ba
Compare
run buildall |
return false; | ||
} | ||
VarcharLiteral varcharLiteral = (VarcharLiteral) format; | ||
String str = varcharLiteral.getValue().replace(" ", ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this action not match the format "yyyy-MM-dd HH:mm:ss"?
// specific language governing permissions and limitations | ||
// under the License. | ||
|
||
suite("always_mono_func") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls also add cases for other 5 types of function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and add negative cases also to ensure the NOT-PRUNE behavior
62b72ba
to
29e6ca9
Compare
run buildall |
TPC-H: Total hot run time: 39863 ms
|
TPC-DS: Total hot run time: 189310 ms
|
ClickBench: Total hot run time: 33.2 s
|
run buildall |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39622 ms
|
TPC-DS: Total hot run time: 196395 ms
|
ClickBench: Total hot run time: 32.28 s
|
f1849a8
to
c43be11
Compare
run buildall |
1 similar comment
run buildall |
TPC-H: Total hot run time: 39642 ms
|
TPC-DS: Total hot run time: 190537 ms
|
ClickBench: Total hot run time: 33.71 s
|
run p0 |
run cloud_p0 |
run p0 |
run cloud_p0 |
run p0 |
run cloud_p0 |
1475058
to
fb99231
Compare
run buildall |
TPC-H: Total hot run time: 32618 ms
|
TPC-DS: Total hot run time: 197031 ms
|
ClickBench: Total hot run time: 31.06 s
|
fb99231
to
9ada9e4
Compare
…plement Monotonic [enhance](nerieds) data_format, to_monday, last_day, to_date, year implement Monotonic
9ada9e4
to
3ce9cf6
Compare
run buildall |
TPC-H: Total hot run time: 32955 ms
|
TPC-DS: Total hot run time: 197100 ms
|
ClickBench: Total hot run time: 32.04 s
|
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
This pr implement Monotonic for date_format, to_monday, last_day, to_date, year, which will allow partition pruning on partition column with there functions.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)