Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix](checker) Fixed infinite loop after internal error in checker. #44479 #44495

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44479

…44479)


When the checker encounters an internal error, such as a transaction
conflict, the return value will be less than 0 and the function will
return immediately, but the related instance will not be removed from
the map. Additionally, if the return value of the do check is not 0, the
inverted check will not be performed. This PR fixes both of these
issues.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 22, 2024
@doris-robot
Copy link

run buildall

Copy link
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring dataroaring merged commit e1b8296 into branch-3.0 Nov 23, 2024
24 checks passed
@github-actions github-actions bot deleted the auto-pick-44479-branch-3.0 branch November 23, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants