Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids)should set isForwardedToMaster and redirectStatus to null before fallback to legacy planner #44333

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

starocean999
Copy link
Contributor

pick from master #44163

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 49497 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 858d0da13e4f982baa38269473e919a636c69d13, data reload: false

------ Round 1 ----------------------------------
q1	17925	4616	4332	4332
q2	2077	163	149	149
q3	10378	2141	1944	1944
q4	10257	1266	1299	1266
q5	8573	4009	3959	3959
q6	238	124	127	124
q7	2061	1654	1587	1587
q8	9331	2770	2735	2735
q9	10640	10397	9895	9895
q10	8678	3569	3570	3569
q11	423	253	244	244
q12	470	291	309	291
q13	18371	3981	4051	3981
q14	355	339	332	332
q15	525	468	467	467
q16	548	455	473	455
q17	1135	985	964	964
q18	7267	7015	6884	6884
q19	1683	1612	1559	1559
q20	544	320	304	304
q21	4523	4221	4060	4060
q22	491	396	406	396
Total cold run time: 116493 ms
Total hot run time: 49497 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4361	4309	4309
q2	327	224	227	224
q3	4202	4168	4142	4142
q4	2775	2760	2760	2760
q5	7256	7201	7126	7126
q6	239	119	120	119
q7	3226	2848	2790	2790
q8	4322	4464	4466	4464
q9	14297	13997	13914	13914
q10	4224	4278	4262	4262
q11	725	716	677	677
q12	1035	847	852	847
q13	6665	3731	3728	3728
q14	459	431	418	418
q15	514	465	456	456
q16	646	611	565	565
q17	3878	3813	3858	3813
q18	8865	8767	8717	8717
q19	1727	1667	1681	1667
q20	2365	2131	2096	2096
q21	8446	8422	8483	8422
q22	1047	947	926	926
Total cold run time: 81585 ms
Total hot run time: 76442 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 212225 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 858d0da13e4f982baa38269473e919a636c69d13, data reload: false

query1	980	395	387	387
query2	6538	2291	2105	2105
query3	6923	204	203	203
query4	22944	21556	21849	21556
query5	19731	6513	6482	6482
query6	290	221	236	221
query7	4336	307	323	307
query8	248	260	253	253
query9	3083	2655	2588	2588
query10	475	305	315	305
query11	15844	15004	15135	15004
query12	128	78	78	78
query13	1046	449	442	442
query14	17421	13377	13522	13377
query15	363	219	243	219
query16	6485	275	262	262
query17	1770	939	924	924
query18	894	329	343	329
query19	221	144	150	144
query20	108	98	105	98
query21	190	96	98	96
query22	5266	4939	5053	4939
query23	34442	33549	33460	33460
query24	6907	6365	6350	6350
query25	514	447	432	432
query26	800	170	161	161
query27	2310	295	296	295
query28	6139	2290	2239	2239
query29	2981	2901	2730	2730
query30	248	171	167	167
query31	949	723	738	723
query32	70	62	61	61
query33	443	271	269	269
query34	865	482	483	482
query35	1159	956	924	924
query36	1371	1146	1185	1146
query37	92	61	62	61
query38	3089	2946	2930	2930
query39	1362	1348	1345	1345
query40	201	94	97	94
query41	43	39	39	39
query42	91	85	84	84
query43	689	548	543	543
query44	1169	726	714	714
query45	246	230	231	230
query46	1233	968	947	947
query47	1880	1786	1784	1784
query48	515	430	416	416
query49	629	375	399	375
query50	876	607	617	607
query51	4768	4730	4677	4677
query52	91	82	82	82
query53	236	185	185	185
query54	2653	2486	2447	2447
query55	85	86	81	81
query56	248	221	214	214
query57	1300	1179	1138	1138
query58	231	217	218	217
query59	3642	3141	3179	3141
query60	229	220	205	205
query61	101	96	99	96
query62	830	468	466	466
query63	198	179	180	179
query64	4961	1647	1551	1551
query65	3638	3562	3575	3562
query66	645	433	408	408
query67	15591	14955	14772	14772
query68	10447	649	621	621
query69	520	275	278	275
query70	1612	1367	1477	1367
query71	415	304	319	304
query72	6950	4907	4790	4790
query73	764	316	320	316
query74	6352	5815	5812	5812
query75	5278	3767	3680	3680
query76	6201	1144	1164	1144
query77	1033	260	257	257
query78	12687	12405	11640	11640
query79	12162	649	659	649
query80	756	380	392	380
query81	491	242	242	242
query82	1417	95	98	95
query83	183	133	131	131
query84	253	72	71	71
query85	884	318	329	318
query86	341	289	293	289
query87	3228	3044	2984	2984
query88	5104	2301	2297	2297
query89	472	299	268	268
query90	2196	208	208	208
query91	167	126	131	126
query92	57	52	52	52
query93	7064	597	571	571
query94	964	211	206	206
query95	1978	2034	2016	2016
query96	655	328	330	328
query97	6464	6442	6359	6359
query98	231	199	214	199
query99	2983	905	882	882
Total cold run time: 326353 ms
Total hot run time: 212225 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 858d0da13e4f982baa38269473e919a636c69d13, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.02	0.02
query3	0.24	0.04	0.04
query4	1.79	0.07	0.06
query5	0.53	0.52	0.51
query6	1.23	0.61	0.61
query7	0.02	0.01	0.00
query8	0.03	0.02	0.03
query9	0.52	0.50	0.48
query10	0.53	0.55	0.53
query11	0.11	0.08	0.08
query12	0.12	0.09	0.09
query13	0.62	0.61	0.62
query14	0.79	0.78	0.78
query15	0.79	0.76	0.75
query16	0.38	0.39	0.38
query17	1.02	1.01	1.02
query18	0.23	0.26	0.22
query19	1.95	1.85	1.86
query20	0.01	0.02	0.01
query21	15.49	0.56	0.54
query22	2.08	2.59	1.50
query23	16.54	0.99	0.98
query24	5.25	0.84	4.70
query25	0.41	0.11	0.05
query26	0.90	0.16	0.16
query27	0.04	0.04	0.03
query28	4.32	0.77	0.81
query29	12.68	2.34	2.34
query30	0.61	0.50	0.52
query31	2.82	0.39	0.38
query32	3.39	0.51	0.50
query33	3.12	3.07	3.06
query34	15.26	4.81	4.83
query35	4.88	4.90	4.83
query36	1.07	1.01	1.03
query37	0.06	0.05	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.15	0.15	0.13
query41	0.07	0.01	0.01
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 100.23 s
Total hot run time: 30.63 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 858d0da13e4f982baa38269473e919a636c69d13 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.7 seconds inserted 10000000 Rows, about 460K ops/s

@starocean999 starocean999 merged commit f7dda9e into apache:branch-2.0 Nov 21, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants