Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-2.1: [fix](profile) only printed for non-sink nodes in the merge profile. #44040 #44252

Merged
merged 1 commit into from
Nov 19, 2024
Merged

branch-2.1: [fix](profile) only printed for non-sink nodes in the merge profile. #44040 #44252

merged 1 commit into from
Nov 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44040

@Mryange
[fix](profile) only printed for non-sink nodes in the merge profile. (#…
34fdd46 
…44040)

### What problem does this PR solve?
In the past, the result sink did not have a plan node ID, which led to
incorrect plan info being output.
 Now, the plan info for sinks is not printed.

before
```
MergedProfile  
          Fragments:
              Fragment  0:
                  Pipeline  :  0(instance_num=1):
                        -  WaitWorkerTime:  avg  30.984us,  max  30.984us,  min  30.984us
                      RESULT_SINK_OPERATOR  (id=0):
                            -  PlanInfo
                                  -  TABLE:  test.big_string_table(big_string_table),  PREAGGREGATION:  ON
                                  -  partitions=1/1  (big_string_table)
                                  -  tablets=3/3,  tabletList=113264,113266,113268
                                  -  cardinality=131072,  avgRowSize=13.638229,  numNodes=1
                                  -  pushAggOp=COUNT
                                  -  projections:  1
                                  -  project  output  tuple  id:  1
                          OLAP_SCAN_OPERATOR  (id=0.  nereids_id=156.  table  name  =  big_string_table(big_string_table)):
```
now
```
MergedProfile  
          Fragments:
              Fragment  0:
                  Pipeline  :  0(instance_num=1):
                        -  WaitWorkerTime:  avg  32.576us,  max  32.576us,  min  32.576us
                      RESULT_SINK_OPERATOR  (id=0):
                          OLAP_SCAN_OPERATOR  (id=0.  nereids_id=156.  table  name  =  big_string_table(big_string_table)):
                                -  PlanInfo
                                      -  TABLE:  test.big_string_table(big_string_table),  PREAGGREGATION:  ON
                                      -  partitions=1/1  (big_string_table)
                                      -  tablets=3/3,  tabletList=113264,113266,113268
                                      -  cardinality=131072,  avgRowSize=0.0,  numNodes=1
                                      -  pushAggOp=COUNT
                                      -  projections:  1
                                      -  project  output  tuple  id:  1
```
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 19, 2024
@doris-robot
Copy link

run buildall

@yiguolei yiguolei merged commit 1b1e2e8 into branch-2.1 Nov 19, 2024
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-44040-branch-2.1 branch November 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doris-robot @yiguolei @dataroaring @Mryange