Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [fix](s3) do not replace https scheme if specified #44242 #44249

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44242

### What problem does this PR solve?

Problem Summary:
When creating s3 resource with endpoint, it user already specify
`https://` schema in endpoint url,
we should not replace it with `http://`.

### Release note

[fix](s3) fix bug that s3 resource do not support `https://`
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 19, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42622 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5b71b1d8ed9c65e7fc62822c4dd727715281046a, data reload: false

------ Round 1 ----------------------------------
q1	17590	7327	7282	7282
q2	2053	162	184	162
q3	10695	1022	1183	1022
q4	10547	799	731	731
q5	7763	2810	2708	2708
q6	233	143	144	143
q7	962	614	594	594
q8	9567	1902	1976	1902
q9	6905	6342	6385	6342
q10	6947	2253	2275	2253
q11	454	264	261	261
q12	406	210	212	210
q13	17811	2938	2935	2935
q14	246	201	211	201
q15	547	519	522	519
q16	675	615	611	611
q17	957	557	553	553
q18	7217	6520	6387	6387
q19	1493	1085	1051	1051
q20	2858	2671	2659	2659
q21	3898	3174	3120	3120
q22	1073	1016	976	976
Total cold run time: 110897 ms
Total hot run time: 42622 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7228	7164	7252	7164
q2	334	247	241	241
q3	3020	2885	2949	2885
q4	1987	1805	1706	1706
q5	5592	5698	5765	5698
q6	225	135	141	135
q7	2126	1727	1772	1727
q8	3303	3393	3444	3393
q9	8842	8901	8763	8763
q10	3535	3527	3517	3517
q11	606	514	488	488
q12	822	628	619	619
q13	16628	3191	3138	3138
q14	316	279	277	277
q15	561	520	512	512
q16	731	670	652	652
q17	1830	1620	1605	1605
q18	8052	7832	7396	7396
q19	8389	1638	1593	1593
q20	2040	1859	1831	1831
q21	5260	5288	5340	5288
q22	1057	1027	999	999
Total cold run time: 82484 ms
Total hot run time: 59627 ms

@morningman morningman merged commit c149e83 into branch-3.0 Nov 19, 2024
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-44242-branch-3.0 branch November 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants