Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) simplify conditional function generate wrong nullable #44209

Merged
merged 1 commit into from
Nov 20, 2024
Merged

[fix](Nereids) simplify conditional function generate wrong nullable #44209

merged 1 commit into from
Nov 20, 2024
+12 −4

Conversation

morrySnow
Copy link
Contributor

What problem does this PR solve?

Related PR: #37613

Problem Summary:

because adjust nullable do not run after simplify confitional function, we should not change any output's nullable in this rule

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

924060929
924060929 previously approved these changes Nov 18, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

run feut

@morrySnow
[fix](Nereids) simplify conditional function generate wrong nullable
03ce915 
related pr apache#37613

because adjust nullable do not run after simplify confitional function,
we should not change any output's nullable in this rule
@morrySnow morrySnow force-pushed the fix_simplify_condition_nullable branch from 687d5e3 to 03ce915 Compare November 19, 2024 09:32
@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Nov 19, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 44823 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03ce915ac3b78ccdb2eaa4587eb794eff093c718, data reload: false

------ Round 1 ----------------------------------
q1	17589	7685	7303	7303
q2	2272	1161	1157	1157
q3	9958	1133	1153	1133
q4	10222	775	737	737
q5	7593	2754	2614	2614
q6	241	150	151	150
q7	989	624	602	602
q8	9364	2361	2358	2358
q9	6667	6421	6472	6421
q10	6977	2265	2318	2265
q11	464	252	259	252
q12	410	211	214	211
q13	17775	3048	2997	2997
q14	254	214	212	212
q15	567	519	501	501
q16	639	572	585	572
q17	972	539	519	519
q18	7443	6947	6734	6734
q19	1331	995	987	987
q20	2919	2724	2733	2724
q21	3924	3243	3049	3049
q22	1392	1329	1325	1325
Total cold run time: 109962 ms
Total hot run time: 44823 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7337	7253	7222	7222
q2	322	225	225	225
q3	2921	2795	2750	2750
q4	1944	1683	1708	1683
q5	5408	5457	5415	5415
q6	220	137	136	136
q7	2087	1690	1729	1690
q8	3286	3397	3422	3397
q9	8558	8525	8520	8520
q10	3525	3437	3438	3437
q11	581	481	497	481
q12	791	596	564	564
q13	10547	3035	3040	3035
q14	290	263	263	263
q15	569	502	515	502
q16	683	634	626	626
q17	1804	1626	1572	1572
q18	7921	7516	7387	7387
q19	1675	1658	1609	1609
q20	2085	1806	1835	1806
q21	5376	5177	5175	5175
q22	642	536	552	536
Total cold run time: 68572 ms
Total hot run time: 58031 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03ce915ac3b78ccdb2eaa4587eb794eff093c718, data reload: false

query1	0.03	0.03	0.05
query2	0.06	0.04	0.03
query3	0.23	0.07	0.07
query4	1.64	0.10	0.10
query5	0.41	0.44	0.40
query6	1.16	0.65	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.59	0.51	0.50
query10	0.55	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	2.68	2.70	2.85
query15	0.92	0.84	0.83
query16	0.38	0.38	0.38
query17	1.04	1.05	1.03
query18	0.24	0.22	0.23
query19	1.95	1.87	2.01
query20	0.02	0.01	0.01
query21	15.36	0.59	0.58
query22	2.73	1.89	2.46
query23	17.13	0.89	0.82
query24	2.86	1.56	1.30
query25	0.47	0.24	0.08
query26	0.47	0.14	0.14
query27	0.05	0.05	0.04
query28	10.81	1.09	1.06
query29	12.51	3.22	3.24
query30	0.24	0.07	0.05
query31	2.88	0.38	0.37
query32	3.28	0.48	0.47
query33	3.02	3.00	3.04
query34	16.97	4.46	4.47
query35	4.55	4.44	4.50
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.34 s
Total hot run time: 32.93 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2024
@morrySnow morrySnow merged commit 0a11a9b into apache:master Nov 20, 2024
27 of 29 checks passed
@morrySnow morrySnow deleted the fix_simplify_condition_nullable branch November 20, 2024 07:55
github-actions bot pushed a commit that referenced this pull request Nov 20, 2024
@morrySnow
[fix](Nereids) simplify conditional function generate wrong nullable (#…
6525a3a 
…44209)

Related PR: #37613

Problem Summary:
because adjust nullable do not run after simplify confitional function,
we should not change any output's nullable in this rule
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
morrySnow added a commit that referenced this pull request Nov 20, 2024
@github-actions @morrySnow
branch-3.0: [fix](Nereids) simplify conditional function generate wro…
55a06fd 
…ng nullable #44209 (#44334)

Cherry-picked from #44209

Co-authored-by: morrySnow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged p0_b reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morrySnow @doris-robot @924060929 @feiniaofeiafei