Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[performance](move-memtable) async close tablet streams (#41156 & #43813) #44128

Merged
merged 2 commits into from
Nov 19, 2024
Merged

[performance](move-memtable) async close tablet streams (#41156 & #43813) #44128

merged 2 commits into from
Nov 19, 2024

Conversation

kaijchen
Copy link
Contributor

backport #41156 and #43813

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaijchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

kaijchen and others added 2 commits November 18, 2024 11:56
@kaijchen
[performance](move-memtable) async close tablet streams (apache#41156)
138d4a3 
Asynchronously close tablet streams to speed up load stream close.
@kaijchen
[fix](move-memtable) error status should not be overwritten in Tablet…
ec69ed2 
…Stream (apache#43813)

Use `AtomicStatus` for `TabletStream::_status` to ensure thread safety.
Use `AtomicStatus::update` to avoid error status being overwritten by
`Status::OK()`
@kaijchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.44% (9515/26109)
Line Coverage: 27.93% (78284/280305)
Region Coverage: 26.59% (40140/150976)
Branch Coverage: 23.39% (20392/87200)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ec69ed236a4df19bb1a5d0ab0974f5a647cbd0e2_ec69ed236a4df19bb1a5d0ab0974f5a647cbd0e2/report/index.html

@kaijchen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.45% (9517/26110)
Line Coverage: 27.94% (78311/280317)
Region Coverage: 26.59% (40144/150979)
Branch Coverage: 23.39% (20398/87202)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ec69ed236a4df19bb1a5d0ab0974f5a647cbd0e2_ec69ed236a4df19bb1a5d0ab0974f5a647cbd0e2/report/index.html

@dataroaring dataroaring merged commit b4e136b into apache:branch-2.1 Nov 19, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaijchen @doris-robot @dataroaring